feat: integrate EventPublisher accross Account module services - #1859
Merged
Merged
Conversation
Assisted-by: Claude Sonnet 5
Assisted-by: Claude Sonnet 5
Assisted-by: Claude Sonnet 5
Assisted-by: Claude Sonnet 5
Assisted-by: Claude Sonnet 5
Assisted-by: Claude Sonnet 5
Assisted-by: Claude Sonnet 5
Assisted-by: Claude Sonnet 5
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1859 +/- ##
==========================================
+ Coverage 55.88% 56.17% +0.28%
==========================================
Files 136 136
Lines 4892 4931 +39
Branches 711 711
==========================================
+ Hits 2734 2770 +36
- Misses 2158 2161 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
laminne
marked this pull request as ready for review
September 17, 2026 12:50
MikuroXina
requested changes
Sep 17, 2026
Assisted-by: Claude Sonnet 5
laminne
enabled auto-merge
September 17, 2026 13:09
MikuroXina
approved these changes
Sep 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #1839
What does this PR do?
EventPublisherをServiceから呼び出し、イベントを正しく取り出して投げられるようにしたAdditional information
Account.setPassphraseHashは(今のところ)ドメインイベントを発行しないので組み込みの対象外にしていますaccount.password.changedイベントを定義するEventPublisher.publishを意図せず1イベントのみ受け取る仕様にしていたので、EventPublisher.publishMany(readonly AnyDomainEvent[])に変更してpublishは廃止しました