Skip to content

feat: integrate EventPublisher accross Account module services - #1859

Merged
laminne merged 9 commits into
mainfrom
feat/1839-event-publisher-accounts
Sep 18, 2026
Merged

laminne merged 9 commits into
mainfrom
feat/1839-event-publisher-accounts

Conversation

@laminne

@laminne laminne commented Sep 16, 2026

Copy link
Copy Markdown
Member

part of #1839

What does this PR do?

Additional information

  • Account.setPassphraseHashは(今のところ)ドメインイベントを発行しないので組み込みの対象外にしています
    • todo: account.password.changedイベントを定義する
  • EventPublisher.publishを意図せず1イベントのみ受け取る仕様にしていたので、EventPublisher.publishMany(readonly AnyDomainEvent[])に変更してpublishは廃止しました

@laminne laminne self-assigned this Sep 16, 2026
@laminne laminne added the T: improvement Improvement of functions, etc. label Sep 16, 2026
@codecov

codecov Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.97872% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.17%. Comparing base (b56538c) to head (648682a).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
pkg/accounts/service/verifyToken.ts 25.00% 3 Missing ⚠️
pkg/accounts/service/edit.ts 88.88% 1 Missing ⚠️
pkg/accounts/service/follow.ts 80.00% 1 Missing ⚠️
pkg/accounts/service/freeze.ts 87.50% 1 Missing ⚠️
pkg/accounts/service/silence.ts 87.50% 1 Missing ⚠️
pkg/accounts/service/unfollow.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1859      +/-   ##
==========================================
+ Coverage   55.88%   56.17%   +0.28%     
==========================================
  Files         136      136              
  Lines        4892     4931      +39     
  Branches      711      711              
==========================================
+ Hits         2734     2770      +36     
- Misses       2158     2161       +3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@laminne
laminne marked this pull request as ready for review September 17, 2026 12:50
@laminne
laminne requested a review from MikuroXina September 17, 2026 12:50
Comment thread pkg/accounts/service/follow.ts Outdated
@laminne
laminne enabled auto-merge September 17, 2026 13:09
@laminne
laminne requested a review from MikuroXina September 17, 2026 13:09
@laminne
laminne added this pull request to the merge queue Sep 18, 2026
Merged via the queue into main with commit c2799b5 Sep 18, 2026
6 checks passed
@laminne
laminne deleted the feat/1839-event-publisher-accounts branch September 18, 2026 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T: improvement Improvement of functions, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants