Repository navigation
Cache compiles and run the suite on every core in CI - #127
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011oXiCXjnYBaoHZs8EwRMRB
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011oXiCXjnYBaoHZs8EwRMRB
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Matteo · project thread
Before: the last main run took 29 min. Every job compiled BART and FINUFFT (588 objects with the SIMD modules) from scratch: 1.5–6.5 min per test leg, and 14 min for the CUDA build, which then ran the whole host suite serially for another 8 min. The suite took 6–8 min per leg on one core; locally 476 s, 296 s of it in
test_cli.py's moba/mobafit fits. Every PR touchingsrc/ordocs/also executed the whole gallery.After: every compile goes through ccache (
hendrikmuhs/ccache-action, one store per matrix leg, nvcc included), with Ninja as the generator, so a run recompiles only what changed. The suite runs under pytest-xdist on every core with--dist worksteal, so the long fits do not queue behind one another: 201 s locally on 4 cores, same results. A PR still renders the reference, which is fast. The executed gallery runs only when a maintainer comments/build-docs, and the run answers on the PR. Main and tags still execute and publish.test_registry_is_empty_after_a_failureasserted the process-wide registry was empty, which depends on what ran earlier in the same process; under worksteal ordering it saw an entry left by another test. It now clears the registry first and still asserts the failure leaves nothing behind.The
/build-docstrigger isissue_comment, read frommain's copy of the workflow, so it works only after this merges.🤖 Generated with Claude Code
https://claude.ai/code/session_011oXiCXjnYBaoHZs8EwRMRB