Skip to content

Bring functional wrappers up to the Simulator API - #25

Merged
mcencini merged 26 commits into
mainfrom
api/functional-wrapper-parity
Oct 5, 2026
Merged

mcencini merged 26 commits into
mainfrom
api/functional-wrapper-parity

Conversation

@mcencini

@mcencini mcencini commented Oct 5, 2026

Copy link
Copy Markdown
Contributor

Summary

  • let the seven existing *_sim convenience functions pass current call-time Simulator settings through instead of freezing the wrapper API at the pre-refactor vocabulary
  • expose current phase schedules on MRF, MPnRAGE, MPRAGE and MP2RAGE wrappers
  • preserve the existing explicit arguments for backwards compatibility
  • fix stale wrapper docstrings and type annotations
  • add parity tests against the corresponding Simulator classes

This intentionally does not create wrappers for every shipped Simulator: the class API remains canonical, while functional wrappers stay a compact convenience layer.

@mcencini
mcencini merged commit 5602b82 into main Oct 5, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant