Repository navigation
Make PyTorch's forward mode ready without its TorchScript warning - #34
Merged
Merged
Conversation
PyTorch's forward mode registers its decompositions through torch.jit.script at its first dual tensor, which warns that torch.jit.script is deprecated. A Jacobian and the linearised operator now load those decompositions first, under the switch PyTorch reads for them, with that warning silenced for the load alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyTorch's forward mode imports
torch._decomp.decompositions_for_jvpat its first dual tensor, and that module scripts its decompositions withtorch.jit.script, which warns that it is deprecated. It is PyTorch's own call, done once per process, building TorchScript graphs and no machine code, so nothing on the target needs a toolchain.blochsim's forward-mode derivatives --
SignalModel.jacobianand the recon operator'sA_jvp-- now load those decompositions first, under the switch PyTorch reads for them (PYTORCH_JIT,__debug__), with that one warning filtered for the load. A simulation and its reverse-mode gradients do not load them at all (#33).Verified: the full suite passes (1614, 3 skipped); the forward-mode tests -- Jacobians, functionals, design, forward-over-reverse, recon -- pass with
-W error:torch.jit.script:DeprecationWarning.🤖 Generated with Claude Code