Repository navigation
feat(l10n): word the title from the shared messages - #14
Merged
Merged
Conversation
The monorepo's messages now live in pf-l10n. The pin brings the kit and the core with their text in one language, and the core words the host's refusals itself. scripts/pins.env and docs/pins.md move with Cargo.toml. The kit's Skia and Opus are unchanged, so only the punktfunk rev in the cache keys moves.
The pin adds RejectReason::ProfileLocked and two ConsoleOptions fields. The copied refusal sentences go: pf-client-core words each reason in the player's language, and the rest of the file reads pf-l10n. A refused dial no longer shows the io cause in the sentence. The warning in the log keeps it.
Horizon's set service gives the console's UI language as a packed language code. It is already a BCP-47 tag, so the platform hands it to the app in DeviceInfo and the app passes it on before any text is read. The kit takes the same list in its options. The title has no language setting of its own and does not need one: the console decides.
The library errors, log upload notices, session end reasons, stats line, pad names, wake and host-action notices, and the applet notice now come from the console and client parts. The applet notice names its button through a placeholder. A LibraryError in the log prints its Debug form, which holds the cause in English. Its Display is the player's sentence.
Sleep and Shut down are the host's own power actions, so the exit menu takes the host part's labels. A picture that stops mid-stream reads the client's existing sentence for an unexpected end.
The pin brings the reworded messages and the merged keys. scripts/pins.env and docs/pins.md move with Cargo.toml. Skia and Opus are unchanged.
The line that says the stream did not start is dial_stream_start_failed now. The cause stays in the log, where the warning above it already writes it.
pf-nx-probe reads NativeClient::link_line, which the shared core puts behind its l10n feature; the title got it through pf-client-core, the probe did not.
GitHub's artifact storage quota turned a green console build red at the upload step; the NRO is proven by the link, and the tester gets it from the next run once the quota clears.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pins punktfunk at
c4d6fe182(#2307 + #2308;pins.envanddocs/pins.mdfollow). The copied reject sentences incore/errors.rsare deleted for the core'sconnect_reject_message; the title's own text reads frompf-l10n. The console's UI language comes from libnxsetGetSystemLanguage(newpf-nx-sys/src/set.rs, symbol confirmed inlibnx.a) intoDeviceInfo.languages, thenset_languagesandConsoleOptions.languages; the dev box passes an empty list (English). No setting.Verified: Mac
cargo fmt,cargo test --workspace, clippy (only the knownRoute::from_rawhit); console type-checkcargo-nx.sh check -p pf-nx -p pf-nx-probe; Linux tests + clippy. Not verified: the Horizon link, anything on a console, any language but English.