Skip to content

feat(l10n): word the title from the shared messages - #14

Merged
enricobuehler merged 10 commits into
mainfrom
feat/l10n
Nov 7, 2026
Merged

enricobuehler merged 10 commits into
mainfrom
feat/l10n

Conversation

@enricobuehler

Copy link
Copy Markdown
Member

Pins punktfunk at c4d6fe182 (#2307 + #2308; pins.env and docs/pins.md follow). The copied reject sentences in core/errors.rs are deleted for the core's connect_reject_message; the title's own text reads from pf-l10n. The console's UI language comes from libnx setGetSystemLanguage (new pf-nx-sys/src/set.rs, symbol confirmed in libnx.a) into DeviceInfo.languages, then set_languages and ConsoleOptions.languages; the dev box passes an empty list (English). No setting.

Verified: Mac cargo fmt, cargo test --workspace, clippy (only the known Route::from_raw hit); console type-check cargo-nx.sh check -p pf-nx -p pf-nx-probe; Linux tests + clippy. Not verified: the Horizon link, anything on a console, any language but English.

The monorepo's messages now live in pf-l10n. The pin brings the kit and
the core with their text in one language, and the core words the host's
refusals itself.

scripts/pins.env and docs/pins.md move with Cargo.toml. The kit's Skia
and Opus are unchanged, so only the punktfunk rev in the cache keys
moves.
The pin adds RejectReason::ProfileLocked and two ConsoleOptions fields.
The copied refusal sentences go: pf-client-core words each reason in
the player's language, and the rest of the file reads pf-l10n.

A refused dial no longer shows the io cause in the sentence. The
warning in the log keeps it.
Horizon's set service gives the console's UI language as a packed
language code. It is already a BCP-47 tag, so the platform hands it to
the app in DeviceInfo and the app passes it on before any text is read.

The kit takes the same list in its options. The title has no language
setting of its own and does not need one: the console decides.
The library errors, log upload notices, session end reasons, stats
line, pad names, wake and host-action notices, and the applet notice
now come from the console and client parts. The applet notice names its
button through a placeholder.

A LibraryError in the log prints its Debug form, which holds the cause
in English. Its Display is the player's sentence.
Sleep and Shut down are the host's own power actions, so the exit menu takes the host part's labels. A picture that stops mid-stream reads the client's existing sentence for an unexpected end.
The pin brings the reworded messages and the merged keys. scripts/pins.env and docs/pins.md move with Cargo.toml. Skia and Opus are unchanged.
The line that says the stream did not start is dial_stream_start_failed now. The cause stays in the log, where the warning above it already writes it.
pf-nx-probe reads NativeClient::link_line, which the shared core puts behind its l10n feature; the title got it through pf-client-core, the probe did not.
GitHub's artifact storage quota turned a green console build red at the upload step; the NRO is proven by the link, and the tester gets it from the next run once the quota clears.
@enricobuehler
enricobuehler merged commit c874723 into main Nov 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant