Repository navigation
feat(packaging): show Punktfunk in the Homebrew Menu for 1.1.0 - #17
Merged
Merged
Conversation
The menu showed the lowercase file name, because package-nro.sh used one argument for both the files and the NACP title. The script now takes the title apart from the name. The title's NRO stays punktfunk.nro in /switch/punktfunk, so an update still replaces one file.
Main has new player-facing work since v1.0.0, so the crates move a minor version. Builds off a tag read 1.1.0+g<sha>, which fits the NACP's 16 bytes.
The release workflow publishes this file as the release body. It now says what changed since v1.0.0, and it keeps the install steps and known limits.
broslife
marked this pull request as ready for review
November 7, 2026 16:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Punktfunk.package-nro.shtakes the title apart from the file name, so the build still writespunktfunk.nroand the install path stays/switch/punktfunk/punktfunk.nro. The data folder is a constant in the code and does not read the title.Cargo.lock.packaging/release-notes.mdnow covers 1.1.0. The install steps and known limits stay.This PR adds no tag.
release.ymlruns only on av*tag, so merging it publishes nothing.Not in this release
PR #15 (clock control) and PR #16 (receive timings) are still drafts and are not on
main, so the notes do not mention them.Test on the console
1.1.0+g<sha>./switch/punktfunk/punktfunk.nrokeeps the pairing and settings.punktfunk-switch-1.1.0+g<sha>.log.The packaging change was checked with stand-ins for
nacptoolandelf2nro, which received the right title and file names. This PC has no Rust toolchain, so CI's build is the first real one.