Skip to content

chore(deps): pin punktfunk 0fc1b6c11 - #27

Merged
enricobuehler merged 3 commits into
mainfrom
chore/punktfunk-pin-0fc1b6c
Nov 15, 2026
Merged

enricobuehler merged 3 commits into
mainfrom
chore/punktfunk-pin-0fc1b6c

Conversation

@enricobuehler

Copy link
Copy Markdown
Member

Moves the core pin from 28c312102 to 0fc1b6c11, as client-ps5 #20 did, and carries the two fixes that client took with it.

Drift from the pin

  • ConsoleOptions gained hides and hdr_no_headroom, ConsoleCmd gained SetHidden and FetchHidden. Hide for me is a profile's own list and this title keeps the profile picker off, so both are off and the two commands are no-ops beside the other profile commands.

Store (core 2250eb646, 27437ea9e)

  • A settings.json that does not parse is kept as settings.json.bad before defaults replace it. Before, the version stamp wrote defaults over it on the same launch.
  • A settings.json that exists but can't be read stays as it is, and nothing is saved until a load reads it.
  • A client key or certificate that exists but can't be read is an error instead of being replaced by a new identity.

Stage (core ef8368f07)

  • A resume frame that played opens the keyframe request window, so a second loss right after it asks at once instead of waiting out up to 100 ms. A refused resume frame leaves the window shut.
  • Core's other recovery fix (49aa9ede7, the held keyframe re-ask) does not apply: this title's keyframe requests leave core at once, outside its window, because the stage keeps its own hold.

Checked on the Mac: cargo test --workspace on the pin and store commits, the stage tests on the last (one new), cargo fmt --all --check, clippy on pf-nx-app (the workspace run stops at the known Route::from_raw hit on macOS).
Not checked: the console target compiles only in CI. Nothing ran on a console.

The shared console gained Hide for me and an HDR question for displays
without headroom. Hide for me belongs to a profile, and this title keeps
the profile picker off, so both stay off here.
A settings document that existed but failed to read, or did not parse,
loaded as defaults, and the version stamp wrote those over it at once:
every pairing and setting lost to one bad read. The client identity went
the same way.

A document that does not parse is now kept as `settings.json.bad`. One
that can't be read stays, and nothing is saved until a load reads it. An
unreadable key or certificate is an error, so the pair every host pinned
stays. This follows the shared client store.
The keyframe request window ran 100 ms from the last request whatever
came after it, so a second loss right after the frame that healed the
first waited out the rest of the window. A resume frame that played
means the request was answered: the next loss is a new one.

A refused resume frame does not open the window, so requests still need
a played repair or the full window between them. This follows the
shared recovery driver.
@enricobuehler
enricobuehler merged commit a332988 into main Nov 15, 2026
2 checks passed
@enricobuehler
enricobuehler deleted the chore/punktfunk-pin-0fc1b6c branch November 15, 2026 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant