Repository navigation
chore(deps): pin punktfunk 0fc1b6c11 - #27
Merged
Merged
Conversation
The shared console gained Hide for me and an HDR question for displays without headroom. Hide for me belongs to a profile, and this title keeps the profile picker off, so both stay off here.
A settings document that existed but failed to read, or did not parse, loaded as defaults, and the version stamp wrote those over it at once: every pairing and setting lost to one bad read. The client identity went the same way. A document that does not parse is now kept as `settings.json.bad`. One that can't be read stays, and nothing is saved until a load reads it. An unreadable key or certificate is an error, so the pair every host pinned stays. This follows the shared client store.
The keyframe request window ran 100 ms from the last request whatever came after it, so a second loss right after the frame that healed the first waited out the rest of the window. A resume frame that played means the request was answered: the next loss is a new one. A refused resume frame does not open the window, so requests still need a played repair or the full window between them. This follows the shared recovery driver.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the core pin from
28c312102to0fc1b6c11, as client-ps5 #20 did, and carries the two fixes that client took with it.Drift from the pin
ConsoleOptionsgainedhidesandhdr_no_headroom,ConsoleCmdgainedSetHiddenandFetchHidden. Hide for me is a profile's own list and this title keeps the profile picker off, so both are off and the two commands are no-ops beside the other profile commands.Store (core
2250eb646,27437ea9e)settings.jsonthat does not parse is kept assettings.json.badbefore defaults replace it. Before, the version stamp wrote defaults over it on the same launch.settings.jsonthat exists but can't be read stays as it is, and nothing is saved until a load reads it.Stage (core
ef8368f07)49aa9ede7, the held keyframe re-ask) does not apply: this title's keyframe requests leave core at once, outside its window, because the stage keeps its own hold.Checked on the Mac:
cargo test --workspaceon the pin and store commits, the stage tests on the last (one new),cargo fmt --all --check, clippy onpf-nx-app(the workspace run stops at the knownRoute::from_rawhit on macOS).Not checked: the console target compiles only in CI. Nothing ran on a console.