Repository navigation
chore(deps): pin punktfunk 12e4dfd1b - #8
Merged
Merged
Conversation
Monorepo #2245 holds a Fixed PyroWave rate through session_bitrate_kbps. This title sends the stored rate to the Hello as is and offers only H.264 and HEVC, so the rule changes nothing here. The pin keeps the client on the core it is tested against. scripts/pins.env and docs/pins.md had fallen behind Cargo.toml and move with it. pins.env feeds the NVK and Skia cache keys, so the first run rebuilds both.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the four shared crates (
punktfunk-core,pf-client-core,pf-console-ui,pf-client-video) fromdd871ad7eto12e4dfd1b, the merge of monorepo #2245 ("hold a Fixed PyroWave rate").Cargo.lockchanges the six monorepo source lines and nothing else.scripts/pins.envanddocs/pins.mdnamed older revs thanCargo.toml(7ef864d4a,e7da9ad3d) and move with it.pins.envis part of the NVK and Skia cache keys, so this run rebuilds both (about 30 min).cargo fmt --check,clippy --workspace --all-targets -D warningsandcargo test --workspace(96 tests) pass. The console lane is the real gate.The connect site (
pf-nx-app/src/session/connect.rs) passessettings.bitrate_kbpstoNativeClient::connectuntouched and setsvideo_codecsandpreferred_codecfromVideoCaps::SWITCH(H.264 and HEVC). The title never offers PyroWave, so core'ssession_bitrate_kbpsreturns the stored rate. Nothing here zeroes it.Draft #7 is not touched.