Skip to content

chore(deps): pin punktfunk 12e4dfd1b - #8

Merged
enricobuehler merged 1 commit into
mainfrom
chore/punktfunk-pin-2245
Nov 1, 2026
Merged

enricobuehler merged 1 commit into
mainfrom
chore/punktfunk-pin-2245

Conversation

@enricobuehler

Copy link
Copy Markdown
Member

Moves the four shared crates (punktfunk-core, pf-client-core, pf-console-ui, pf-client-video) from dd871ad7e to 12e4dfd1b, the merge of monorepo #2245 ("hold a Fixed PyroWave rate").

  • Cargo.lock changes the six monorepo source lines and nothing else.
  • scripts/pins.env and docs/pins.md named older revs than Cargo.toml (7ef864d4a, e7da9ad3d) and move with it. pins.env is part of the NVK and Skia cache keys, so this run rebuilds both (about 30 min).
  • No API drift: Mac cargo fmt --check, clippy --workspace --all-targets -D warnings and cargo test --workspace (96 tests) pass. The console lane is the real gate.

The connect site (pf-nx-app/src/session/connect.rs) passes settings.bitrate_kbps to NativeClient::connect untouched and sets video_codecs and preferred_codec from VideoCaps::SWITCH (H.264 and HEVC). The title never offers PyroWave, so core's session_bitrate_kbps returns the stored rate. Nothing here zeroes it.

Draft #7 is not touched.

Monorepo #2245 holds a Fixed PyroWave rate through session_bitrate_kbps.
This title sends the stored rate to the Hello as is and offers only
H.264 and HEVC, so the rule changes nothing here. The pin keeps the
client on the core it is tested against.

scripts/pins.env and docs/pins.md had fallen behind Cargo.toml and move
with it. pins.env feeds the NVK and Skia cache keys, so the first run
rebuilds both.
@enricobuehler
enricobuehler merged commit 3047c18 into main Nov 1, 2026
2 checks passed
@broslife
broslife deleted the chore/punktfunk-pin-2245 branch November 5, 2026 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant