Repository navigation
feat(stream): automatic bitrate on the page - #65
Closed
enricobuehler wants to merge 1 commit into
Closed
enricobuehler wants to merge 1 commit into
enricobuehler wants to merge 1 commit into
Conversation
enricobuehler
force-pushed
the
feat/web-abr
branch
2 times, most recently
from
October 30, 2026 17:23
b105e24 to
ea4d09e
Compare
enricobuehler
force-pushed
the
fix/web-quality-dot
branch
from
October 30, 2026 17:25
b6c7cac to
84da5fc
Compare
The page streamed at the rate the host resolved and never moved it. The driver is core's, fed through `abr::feed` the way the native pump feeds it: the session's counters, loss positions, ring drops, decode and host encode times, keyframe asks and the host's bitrate acks. Its rate asks go out as `SetBitrate`. The stream ceiling is core's too. No clock offset is measured and no probe is asked for yet, so loss and acks drive it.
enricobuehler
force-pushed
the
feat/web-abr
branch
from
October 30, 2026 17:25
ea4d09e to
2b090b6
Compare
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Design:
web-client-tcp-bridge.md§7 (decision D12).The page streamed at the rate the host resolved and never moved it. Now core's ABR driver runs on the page, fed through
punktfunk_core::abr::feedthe way the native pump feeds it. Everything lives inpackages/stream/rust/abr.rs;session.rscalls in at the Welcome, per access unit, per control frame (BitrateChanged, acceptedReconfigured) and per pump.ClientHello.abr_features = EXT_ABR_ACK_REASON. Acks go into the next tick, and the driver'sSetBitrategoes out on the control stream.Session::stats, loss positions, shard delays (drained only), this session's ring drops, decode time frompf_hud_decoded, host encode time and timings from 0xCF, recovery keyframe asks.clock_offset_ns: 0), so no one-way-delay signal. EveryProbegoes back ason_probe_dropped.Report/Shape/LinkRaterideFeedbacklevels the page does not send yet. Loss and acks drive it.FLAG_PROBEframes never reach the decoder now (there was no guard before).Pin note. This builds against monorepo branch
refactor/abr-feed(local, unpushed). Thepunktfunk-corepin inpackages/stream/Cargo.tomlmust be bumped to a rev that includes it before this merges, so CI's wasm job fails until then.stream_cap_kbpscalls core'sabr::stream_ceiling_kbps, exported by monorepo commit 45b4b1b11 onrefactor/abr-feed(the same branch this pin bump needs).Checked locally against that branch through a path patch (not committed):
cargo fmt --check,cargo clippy(host and wasm,-D warnings),cargo test(21 pass, 2 new),build.shlinks,npm testandnpm run checkunchanged.