Repository navigation
fix(console): show profile pictures - #68
Merged
Merged
Conversation
A host row names its picture and the shell asks for it with FetchAvatar. Both pickers need it, so the app reads it over the existing host path and hands the bytes to the wasm shell, and the DOM picker draws the same one. The pin moves to the punktfunk commit that adds the command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A host row names its picture and the shell asks for it with
FetchAvatar. The app reads it over the existing host path and hands the bytes to the wasm shell through the newpf_console_avatarexport. The DOM picker draws the same picture.A picture that won't load leaves the initials.
Pins Punktfunk at dd871ad7e, the merge of unom/punktfunk#2217. client-tizen follows this merge through
client-web.ref.Verification, on this head:
packages/stream/build.sh: wasm builds and exportspf_console_avatar.npm run check: no type errors.npm teston Node 24: 85 and 4 passed. Node 26 dropped--experimental-transform-types.server:cargo check --locked --all-targets.Not tried against a live host.