Skip to content

chore(deps): pin punktfunk 12e4dfd1b - #69

Merged
enricobuehler merged 1 commit into
mainfrom
chore/pin-punktfunk-12e4dfd1b
Oct 31, 2026
Merged

enricobuehler merged 1 commit into
mainfrom
chore/pin-punktfunk-12e4dfd1b

Conversation

@enricobuehler

Copy link
Copy Markdown
Member

Moves the four punktfunk pins (punktfunk-core, pf-console-ui, pf-client-core, and the server's core) from dd871ad7e to 12e4dfd1b, punktfunk main with #2245 (hold a Fixed PyroWave rate). Lockfiles moved for the git packages only.

No driver change. #2245 puts the stored-rate rule in punktfunk_core::quic::session_bitrate_kbps: a client that offered PyroWave as its preference gets Automatic when the host lands on another codec. The native pump applies it; the page does not need to. pf_session_codecs masks the offer to H.264 / HEVC / AV1, so PREFERRED and CODECS never carry CODEC_PYROWAVE and the rule returns asked_kbps unchanged. The host applies the same rule to the same Hello and reads the same number.

Nothing zeroes a stored rate on the way to pf_session_hello: settings.ts clamps a positive rate to 500..200000 and anything else to 0; app.ts streamOptions sends prefs.bitrateKbps; engine.ts passes opts.bitrateKbps ?? 0 (an SDR or codec-fallback restart reuses the same options); pf_session_hello puts it in Hello.bitrate_kbps and Abr::new reads the same field. So a stored rate stays a Fixed H.26x rate, which the driver's new fixed_kbps path watches and never moves.

Checked on a Mac: npm ci, npm run check, npm test (Node 24; 85 + 4 pass), cargo fmt --check, cargo clippy --all-targets, cargo clippy --target wasm32-unknown-emscripten, cargo test for packages/stream and server (--locked). Not run locally: the emsdk wasm link, Storybook, the screenshots, the image. CI covers those.

The rev is punktfunk main at 12e4dfd1b. It carries #2245, which holds a Fixed rate through the bring-up ramp and moves the stored-rate rule into core's `session_bitrate_kbps`. The page offers no PyroWave, so that rule returns the player's rate unchanged and the driver needs no change. The server follows the same rev.
@enricobuehler
enricobuehler merged commit e9dfd4f into main Oct 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant