Repository navigation
fix(web): let the captured-mouse line fade after six seconds - #72
Merged
Merged
Conversation
The line that says how to release a captured mouse stayed over the picture for as long as the mouse was captured, which in a game is the whole session. It now shows each time capture starts and fades with the exit hint's own six seconds. Reported as unom/punktfunk#2298.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reported on Discord against 0.3.3 (unom/punktfunk#2298): with the mouse captured, the line "Mouse captured — press Esc to release" stays over the picture and never goes away.
It was shown for as long as the pointer was captured, with no timer. In a game that is the whole session. It now appears each time capture starts and fades after six seconds, the same animation the exit hint already uses.
Checked
tscin both workspaces; page tests 90 + 4._screens.html?s=streaming-captured) in headless Chromium and WebKit: opacity 1 at 1.5 s, 0 at 7 s.Not checked
A real stream with a real pointer lock: capture, wait, release, capture again.