Repository navigation
Chore/adopt build sdk 1.0.3 - #48
Merged
Merged
Conversation
Moves from Purview.BuildSdk 1.0.0 and Purview.SourceGeneratorFramework 1.0.0-prerelease.54 to the first stable releases of both. The SDK upgrade initially failed with 13 IDE0130 errors, because the SDK stripped 'SourceGeneration' and 'CodeFixes' from RootNamespace and turned Purview.Aspire.ResourceKit.SourceGeneration.* into Purview.Aspire.ResourceKit.* while every type there declares the former. That is fixed in the SDK - Roslyn component names are no longer stripped - rather than worked around per project, so no NamespaceRemoveSuffix opt-outs were added. Example.AppHost now declares its two NoWarn entries as deliberate through PurviewPolicyExemptNoWarn. The SDK's style policy (PRSGD0008) fails the build when a project silences an accessibility rule, and this project silences CA1034 and CA1062: an Aspire AppHost nests the public options types the resource kit binds, which is the shape CA1034 objects to, and its composition code is reached only from this executable's own entry point, so CA1062's public-API argument checks add nothing. Declaring the exemption is the SDK's supported mechanism and keeps the rest of the accessibility policy enforced, unlike DisablePurviewStylePolicyValidation. TargetFrameworks stays on the repository's own AllTargetFrameworks property rather than selecting a curated PurviewTargetFrameworkSet: it already centralises the list in Versions.props and also feeds DefaultTargetFramework, so switching it is a refactor with no behaviour change. Tests: 345 total, 333 passed, 3 skipped. The 9 failures are environmental and unrelated: the Aspire host tests pull postgres and pgweb images, and this machine's Docker daemon cannot resolve DNS (registry-1.docker.io and mcr.microsoft.com both time out against 192.168.33.1:53).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.