Repository navigation
Adopting Source Generator Framework (GA) - #142
Merged
Merged
Conversation
Moves from Purview.BuildSdk 1.0.0 and Purview.SourceGeneratorFramework 1.0.0-prerelease.54 to the first stable releases of both. No source changes were needed. The SDK upgrade initially failed with 24 IDE0130 errors and 192 warnings, because the SDK stripped 'SourceGenerator' from RootNamespace and turned Purview.Telemetry.SourceGenerator.* into Purview.Telemetry.* while every type here declares the former. That is fixed in the SDK - Roslyn component names are no longer stripped - rather than worked around per project, so no NamespaceRemoveSuffix opt-outs were added. The integration tests keep their explicit TargetFrameworks list rather than selecting a curated PurviewTargetFrameworkSet: they target net8.0;net9.0;net10.0 plus net48 on Windows only, and no set covers a .NET Framework target. Tests: 2168, 0 failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.