Repository navigation
ci: run release tests serially - #296
Merged
Merged
Conversation
The cli-e2e global setup installs and later uninstalls @push-based/user-flow at the workspace root from the local verdaccio registry. The nx-plugin tests shell out to npx @push-based/user-flow. With the default Nx parallelism in the release workflow those tasks overlap, the workspace node_modules is rewritten mid-test, and the nx-plugin tests fail with no useful output. The ci workflow already runs tests with --parallel=false, which is why the same tests pass there. Align the release workflow with it.
❗❗❗ report generated by this PR ❗❗❗☕ Order Coffee ☕Date/Time: 2026-10-23 21:28
|
☕ Order Coffee ☕Date/Time: 2026-10-23 21:28
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The release workflow's test step fails on main (see the last two release runs) in
nx-plugin:testandnx-plugin-integration:testwith no useful error output, while the same tests pass in theciworkflow for every PR.Cause: the cli-e2e global setup runs
npm install -D @push-based/user-flow@1.0.0from the local verdaccio registry at the workspace root, and uninstalls it on teardown. The nx-plugin tests shell out tonpx @push-based/user-flow. Theciworkflow runs tests with--parallel=false, so these never overlap. The release workflow runsnx run-many -t testwith default parallelism, so the workspacenode_modulesgets rewritten while the nx-plugin tests are executing, and theirnpxcalls die silently.Verified on a throwaway diagnostic PR (#295) that the published CLI and
nx-plugin:testboth behave correctly on the runner with the release workflow's setup-node configuration when run serially.Change
Add
--parallel=falseto the release workflow's test step, matchingci.yml.