Issue 250 literal include code examples - #667
Conversation
some wordsmithing in pyproject-toml-python-oacjage-metadata.md updated declare-dependencies.md with literalinclude updated pyproject.toml to reflect the previous intention with the hard-coded examples as close as possible
added literalinclude pointing to examples/pure-hatch/pyproject.toml add ipa pronunciations for PyPI
changed literalinclude to reference existing files add additional commentary on dependencies and dependency-groups
Co-authored-by: Jonny Saunders <sneakers-the-rat@protonmail.com>
|
this looks good, could we update this against |
|
hey everyone 👋🏻 @gchambers11 thank you so much for this pr and thank you everyone for the reviews. @gchambers11 it looks like we need to fix a merge conflict. Are you comfortable with one of you fixing that for you so we can update from main? Or would you rather do a rebase on your end? Thank you again! |
|
I wonder because the "maintainers are allowed to make edits tot he pr" is checked if that means @gchambers11 is ok with us cleaning things up so we can review and merge. I'd love to do that if possible! |
|
@all-contributors please add @gchambers11 for docs |
|
I've put up a pull request to add @gchambers11! 🎉 |
|
@lwasser @sneakers-the-rat I’ve resolved the merge conflict with |
6 participants
This PR relates to issue #250 which was worked on at pyconus-26.
The code examples in the markdown files in
package-structure-code/andtests/have been updated to use{literalinclude}as requested in the issue.Some additional documentation was added to
package-structure-code/pyproject-toml-python-package-metadata.mdon including dependencies in pyproject.toml which should be reviewed.The appearance of the code snippets should mostly be unchanged before and after this PR.