Skip to content

Stop telling a reader the menu sections are ARIA menus #207

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DZPM merged 1 commit into from
Oct 8, 2026
Merged

Stop telling a reader the menu sections are ARIA menus #207

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 23 additions & 4 deletions themes/pybcn_theme/layouts/partials/nav.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,32 @@
{{ $currentPage := . }}
{{ range .Site.Menus.main }}
{{ if .HasChildren }}
{{ $dropdown_id := printf "navbar_dropdown_%s" (.Name | urlize) }}
{{/* A section of the menu that opens a list of links, which
is the disclosure pattern of the ARIA practices: a
control that says whether it is open, and the content
it shows. role="button" and aria-expanded carry that.

Not an ARIA menu. aria-haspopup="true" means a menu,
and the div under it used to name itself after the
control with aria-labelledby, which the HTML validator
rejects on a div with no role: three errors on each of
the 247 pages. The way to make them valid is
role="menu" on the div and role="menuitem" on each
link, and that is a promise this does not keep. An
ARIA menu owes the keyboard arrow keys between the
items, a roving tabindex, and Escape to close, and
Bootstrap 4 gives none of the three here. A reader who
is told it is a menu and finds a list of links is
worse off than one who was told nothing. Two
attributes go instead of one arriving.

The id went with the label: nothing else read it. */}}
<li class="nav-item dropdown">
<a class="nav-link dropdown-toggle {{ if $currentPage.HasMenuCurrent "main" . }}active{{ end }}" id="{{ $dropdown_id }}" data-toggle="dropdown" href="{{ .URL }}" role="button" aria-haspopup="true" aria-expanded="false">{{ .Name }}</a>
<div class="dropdown-menu" aria-labelledby="{{ $dropdown_id }}">
<a class="nav-link dropdown-toggle {{ if $currentPage.HasMenuCurrent "main" . }}active{{ end }}" data-toggle="dropdown" href="{{ .URL }}" role="button" aria-expanded="false">{{ .Name }}</a>
<div class="dropdown-menu">
{{ range .Children }}
{{ if .HasChildren }}
<a class="nav-link dropdown-toggle open-submenu {{ if $currentPage.HasMenuCurrent "main" . }}active{{ end }}" data-toggle="dropdown" href="#" role="button" aria-haspopup="true" aria-expanded="false">{{ .Name }}</a>
<a class="nav-link dropdown-toggle open-submenu {{ if $currentPage.HasMenuCurrent "main" . }}active{{ end }}" data-toggle="dropdown" href="#" role="button" aria-expanded="false">{{ .Name }}</a>
<div class="submenu hidden">
{{ range .Children }}
<a class="nav-link {{ if $currentPage.IsMenuCurrent "main" . }}active{{ end }}" {{ if hasPrefix .URL "http" }}target="_blank"{{end}} href="{{ .URL | absURL }}">{{ .Name }} {{if hasPrefix .URL "http"}}<i class="fas fa-external-link-alt" aria-hidden="true"></i>{{end}}</a>
Expand Down
Loading