Repository navigation
fix: support X-WWW-Authenticate fallback in DigestAuth - #1332
Open
AdityaSreevatsaK wants to merge 2 commits into
Open
AdityaSreevatsaK wants to merge 2 commits into
AdityaSreevatsaK wants to merge 2 commits into
Conversation
PR overviewNo security issues were found in this pull request. Reviews
|
Merging this PR will not alter performance
Comparing Footnotes
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #846.
Some devices, such as Fronius solar inverters, return the non-standard
X-WWW-Authenticateheader instead ofWWW-Authenticatewhen requesting Digest authentication.Currently,
DigestAuthignores this header, preventing authentication from proceeding.This PR adds support for
X-WWW-Authenticateas a fallback while preserving existing behaviour:WWW-Authenticateheader when both are present.X-WWW-Authenticateonly when the standard header is absent.Testing:
Checklist