Repository navigation
Increase the bounded SSE event limit for larger responses - #1333
Open
AdityaSreevatsaK wants to merge 2 commits into
Open
AdityaSreevatsaK wants to merge 2 commits into
AdityaSreevatsaK wants to merge 2 commits into
Conversation
Merging this PR will not alter performance
Comparing Footnotes
|
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 5 files
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1259.
SSE events can legitimately exceed the 1 MiB limit introduced in v2.10.0, including MCP
tools/listresponses. Applications using the default SSE configuration currently fail on those events.max_event_sizefrom 1 MiB to 8 MiB, while retaining an explicit per-event buffer limit. A caller can still set a smaller limit, a larger limit, orNoneto disable it.SSEEventTooLarge(SSEError)for size-limit failures, allowing downstream consumers to distinguish deterministic oversize errors from transient transport errors. Existingexcept SSEErrorhandlers remain compatible.Design consideration: 8 MiB is a proposed bounded default, not a fixed requirement. It permits the reported 1.4 MiB response, at the cost of an increased maximum per-event buffer allocation. I am open to adjusting the default or exception design based on maintainer feedback. The approach is also outlined on issue #1259.
Validation
401 Unauthorizedbecause the fork is not authorised for CodSpeed. Upstream PR checks should validate the integration.Checklist
Prepared with AI assistance. The changes and linked validation results were reviewed before submission.