Skip to content

Changes for schema registry for tuning tools - #335

Merged
gubaidulinvadim merged 14 commits into
mainfrom
schema-registry-tuning-tools
Aug 24, 2026
Merged

Changes for schema registry for tuning tools#335
gubaidulinvadim merged 14 commits into
mainfrom
schema-registry-tuning-tools

Conversation

@TeresiaOlsson

@TeresiaOlsson TeresiaOlsson commented Jul 14, 2026

Copy link
Copy Markdown
Member

I decided to make the modifications of the tuning tools in one PR because the response matrices, measurement tools and tuning tools affect at many places.

Edit from @gubaidulinvadim : Resolves #321 #322 #323 #324 #325 #326

@TeresiaOlsson TeresiaOlsson self-assigned this Jul 14, 2026
@TeresiaOlsson
TeresiaOlsson marked this pull request as ready for review July 14, 2026 19:00
@TeresiaOlsson TeresiaOlsson changed the title Schema registry tuning tools Changes for schema registry for tuning tools Jul 14, 2026
Base automatically changed from schema-registry-rf to main July 24, 2026 13:09
@gubaidulinvadim
gubaidulinvadim self-requested a review August 6, 2026 08:48
gubaidulinvadim
gubaidulinvadim previously approved these changes Aug 7, 2026
@TeresiaOlsson
TeresiaOlsson dismissed gubaidulinvadim’s stale review August 7, 2026 14:29

The merge-base changed after approval.

@gubaidulinvadim
gubaidulinvadim self-requested a review August 7, 2026 14:29
gubaidulinvadim
gubaidulinvadim previously approved these changes Aug 7, 2026
@gubaidulinvadim

Copy link
Copy Markdown
Member

@TeresiaOlsson I might've messed something up, please have a look once you are back to work :)

@gubaidulinvadim

Copy link
Copy Markdown
Member

@TeresiaOlsson Before merging please check that nothing got really broken after my meddling here.

@gubaidulinvadim gubaidulinvadim added the enhancement New feature or request label Aug 21, 2026
@TeresiaOlsson

Copy link
Copy Markdown
Member Author

I will be back from holiday to tomorrow so will go through and fix the conflicts.

@TeresiaOlsson

Copy link
Copy Markdown
Member Author

I have rebased so the tests pass now but @gubaidulinvadim what was the reason for adding MeasurementToolConfigModel back? Can I remove it again?

@TeresiaOlsson

Copy link
Copy Markdown
Member Author

I have rebased so the tests pass now but @gubaidulinvadim what was the reason for adding MeasurementToolConfigModel back? Can I remove it again?

Ahh.... It's because of the BBA. I will keep it then in this PR and remove it in another PR where I update the BBA modules since they are new.

That means this PR is ready for review and merge.

@gubaidulinvadim
gubaidulinvadim merged commit 6e28b79 into main Aug 24, 2026
4 checks passed
@gubaidulinvadim
gubaidulinvadim deleted the schema-registry-tuning-tools branch August 24, 2026 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

3 participants