Repository navigation
Retire replaced background worker pools without blocking - #407
Open
Apeksha9389 wants to merge 1 commit into
Open
Apeksha9389 wants to merge 1 commit into
Apeksha9389 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resetting the background worker pool currently abandons the previous executor without shutting it down. Retire that pool with
shutdown(wait=False)after successfully creating its replacement, allowing running and queued cache calculations to finish while preventing further submissions to the old pool.Fixes #404; addresses item 15 in #367.
Two regression tests verify that reset returns while old work is blocked, queued work still completes, the replacement accepts new work, the old pool rejects new submissions, and failed replacement creation preserves the usable original pool. The retirement assertion fails on master. The targeted worker/executor tests pass (5 tests).
Repository Ruff and formatting checks pass. Mypy matches master exactly: three existing SQL backend errors with the installed dependencies, no new diagnostics. Broader local-backend validation: 354 tests passed, 7 skipped, and 8 external-backend cases deselected. One subprocess test initially failed because the runner lacked
pythonon PATH and was launched outside the repository; it passed when rerun from the repository with the virtual environment on PATH. Thus all 355 executed local tests passed across the suite and corrected-environment rerun. External database services were not exercised.Prepared with AI assistance; behavior and regression tests were verified locally.