Skip to content

Missing document of WeakValueDictionary.itervaluerefs #127388

Closed

Description

Documentation

WeakValueDictionary.itervaluerefs in https://github.com/python/cpython/blob/main/Lib/weakref.py#L186 has no document.

The document once existed, but removed in commit ecaab83. Perhaps the function itself should be removed.

Linked PRs

Activity

  1. ghost added
    docsDocumentation in the Doc dir
    on Nov 29, 2024
  2. sobolevn commented on Nov 29, 2024

    @sobolevn
    Member

    Good find! My first thought is that we've long passed the py3 migration point, it would not be safe to remove this function. But, since it is public, tested, and semi-documented (in the source code), maybe we should instead document it again? Since I am not an expert in weakref module, this is a question for others :)

  3. skirpichev commented on Nov 30, 2024

    @skirpichev
    Member
  4. added
    stdlibStandard Library Python modules in the Lib/ directory
    on Nov 30, 2024
  5. serhiy-storchaka commented on Nov 30, 2024

    @serhiy-storchaka
    Member

    It looks that itervaluerefs() and iterkeyrefs() were planned to be renamed to valuerefs() and keyrefs(). But that change was incomplete and it was later partially reverted. We should investigate the history of these changes and find reasons for incompleting and reversion (it may be just mistake). cc @warsaw.

  6. added a commit that references this issue on Oct 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    docsDocumentation in the Doc dirstdlibStandard Library Python modules in the Lib/ directory

    Projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions