You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Missing document of WeakValueDictionary.itervaluerefs #127388
Good find! My first thought is that we've long passed the py3 migration point, it would not be safe to remove this function. But, since it is public, tested, and semi-documented (in the source code), maybe we should instead document it again? Since I am not an expert in weakref module, this is a question for others :)
It looks that itervaluerefs() and iterkeyrefs() were planned to be renamed to valuerefs() and keyrefs(). But that change was incomplete and it was later partially reverted. We should investigate the history of these changes and find reasons for incompleting and reversion (it may be just mistake). cc @warsaw.
Activity
sobolevn commentedon Nov 29, 2024
Good find! My first thought is that we've long passed the py3 migration point, it would not be safe to remove this function. But, since it is public, tested, and semi-documented (in the source code), maybe we should instead document it again? Since I am not an expert in
weakrefmodule, this is a question for others :)skirpichev commentedon Nov 30, 2024
CC @freddrake
serhiy-storchaka commentedon Nov 30, 2024
It looks that
itervaluerefs()anditerkeyrefs()were planned to be renamed tovaluerefs()andkeyrefs(). But that change was incomplete and it was later partially reverted. We should investigate the history of these changes and find reasons for incompleting and reversion (it may be just mistake). cc @warsaw.gh-127388: Restore WeakValueDictionary.itervaluerefs documentation (#…