Correct 32-bit code alignment of perf_trampoline's trampoline_api - #155949
Correct 32-bit code alignment of perf_trampoline's trampoline_api#155949MaxistheSpy wants to merge 3 commits into
perf_trampoline's trampoline_api#155949Conversation
… bytes bit byte confusion here, perf trampoline was previously aligned to 32 bytes, significantly overallocating space per trampoline
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
It's not a trivial fix, so it needs an issue. |
picnixz
left a comment
picnixz
left a comment
There was a problem hiding this comment.
If there is no issue you can't have a NEWS entry. If @pablogsal thinks there is no need for one, remove that NEWS (for now, remove it).
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be put in the comfy chair! |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Should I add an issue just to then have this pr close it? I'm happy to I just want to make sure that's procedure. I thought the issue policy was so changes are justified |
|
What falls under "trivial" is generally: typos/docs/tests or amendments of a previous commit (though in this case, it's better to reuse the issue number of that previous commit). When it affects core components, the issue serves both as a discussion (to confirm the bug) and as a way to track the history of the change. But if you're right about the codeunit (I didn't really check), then I believe it could also be considered trivial. I just want Pablo to acknowledge the issue as he's the maintainer of that part and I'm not familiar enough with it. For now I'm just adding a skip issue and skip news, so you can remove the NEWS entry as well. We'll write a proper one if needed. |
picnixz
changed the title
perf_trampoline's trampoline_api
2 participants
bit byte confusion here, perf trampoline was previously aligned to 32 bytes, significantly overallocating space per trampoline
Code comment states we align to 32 bits, but units are in bytes, so we align 8* larger then we mean to.
Pull Request title
trivial fix does not need an issue number