Skip to content

gh-126970: Correct LOAD_GLOBAL stack order documentation - #159851

Merged
StanFromIreland merged 1 commit into
python:mainfrom
limadog9:gh-126970-load-global-stack-docs
Oct 22, 2026
Merged

gh-126970: Correct LOAD_GLOBAL stack order documentation#159851
StanFromIreland merged 1 commit into
python:mainfrom
limadog9:gh-126970-load-global-stack-docs

Conversation

@limadog9

@limadog9 limadog9 commented Oct 20, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

Describe the current LOAD_GLOBAL stack order in its main documentation: when the low argument bit is set, the global is followed by NULL. Record the stack-order change under Python 3.13 while keeping the flag's introduction under Python 3.11.

Fixes #126970.

Validation:

  • Checked the interpreter's LOAD_GLOBAL macro and verified disassembly, the low-bit flag, stack effects, and call/value behavior on a current free-threaded debug build.
  • Full HTML documentation build with warnings treated as errors.
  • Sphinx lint and patchcheck.

@bedevere-app bedevere-app Bot mentioned this pull request Oct 20, 2026
Closed
@bedevere-app bedevere-app Bot added awaiting review docs Documentation in the Doc dir skip news labels Oct 20, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Docs PRs Oct 20, 2026
@read-the-docs-community

read-the-docs-community Bot commented Oct 20, 2026

Copy link
Copy Markdown

Documentation build overview

📚 cpython-previews | 🛠️ Build #35258728 | 📁 Comparing 705535c against main (6044c62)

  🔍 Preview build  

1 file changed
± library/dis.html

@StanFromIreland
StanFromIreland merged commit 79a9ca0 into python:main Oct 22, 2026
40 checks passed
@StanFromIreland StanFromIreland added awaiting merge needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Oct 22, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in Docs PRs Oct 22, 2026
@miss-islington-app

miss-islington-app Bot commented Oct 22, 2026

Copy link
Copy Markdown

Thanks @limadog9 for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Oct 22, 2026

Copy link
Copy Markdown

Thanks @limadog9 for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.15.
🐍🍒⛏🤖

@StanFromIreland

StanFromIreland commented Oct 22, 2026

Copy link
Copy Markdown
Member

Merged, thanks.

@bedevere-app

bedevere-app Bot commented Oct 22, 2026

Copy link
Copy Markdown

GH-160348 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Oct 22, 2026
@bedevere-app

bedevere-app Bot commented Oct 22, 2026

Copy link
Copy Markdown

GH-160349 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Oct 22, 2026
StanFromIreland pushed a commit that referenced this pull request Oct 22, 2026
@miss-islington @limadog9
[3.14] gh-126970: Correct LOAD_GLOBAL stack order documentation (GH…
f7a7b4b 
…-159851) (#160348)

(cherry picked from commit 79a9ca0)

Co-authored-by: limadog9 <jakewallin42@gmail.com>
StanFromIreland pushed a commit that referenced this pull request Oct 22, 2026
@miss-islington @limadog9
[3.15] gh-126970: Correct LOAD_GLOBAL stack order documentation (GH…
010d391 
…-159851) (#160349)

(cherry picked from commit 79a9ca0)

Co-authored-by: limadog9 <jakewallin42@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

Assignees

No one assigned

Labels

awaiting merge docs Documentation in the Doc dir skip news

Projects

Docs PRs
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

inconsistency in 3.13 LOAD_GLOBAL docs

2 participants

@limadog9 @StanFromIreland