Repository navigation
[3.15] gh-148919: Make test_redirect_no_path independent of proxy environment variables (GH-148920) - #160846
Merged
Conversation
…ronment variables (pythonGH-148920) * pythongh-148919: Make test_redirect_no_path independent of proxy environment variables * pythongh-148919: Also make test_redirect_encoding independent of proxy env test_redirect_encoding uses build_opener(), which installs the default ProxyHandler, so it failed the same way when http_proxy was set. Move the environment cleanup into a helper and use EnvironmentVarGuard.unset(). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- (cherry picked from commit d854380) Co-authored-by: sendaoYan <yansendao@hygon.cn> Co-authored-by: Senthil Kumaran <senthil@python.org> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
orsenthil
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_urllib2.HandlerTests.test_redirect_no_path fails when proxy environment variables are set #148919: Make test_redirect_no_path independent of proxy environment variables
test_urllib2.HandlerTests.test_redirect_no_path fails when proxy environment variables are set #148919: Also make test_redirect_encoding independent of proxy env
test_redirect_encoding uses build_opener(), which installs the default
ProxyHandler, so it failed the same way when http_proxy was set. Move
the environment cleanup into a helper and use EnvironmentVarGuard.unset().
Co-Authored-By: Claude Opus 5.5 noreply@anthropic.com
(cherry picked from commit d854380)
Co-authored-by: sendaoYan yansendao@hygon.cn
Co-authored-by: Senthil Kumaran senthil@python.org
Co-authored-by: Claude Opus 5.5 noreply@anthropic.com