Repository navigation
gh-137549: Handle BaseExceptionGroup in asyncio.Timeout.__aexit__ - #160957
Merged
Merged
Conversation
asyncio.timeout() inserted TimeoutError into the context chain of sub-exceptions only for ExceptionGroup; do the same for BaseExceptionGroup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
asvetlov
requested review from
1st1,
kumaraditya303 and
willingc
as code owners
October 30, 2026 08:30
asvetlov
added
topic-asyncio
needs backport to 3.14
kumaraditya303
approved these changes
Oct 30, 2026
|
Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-160960 is a backport of this pull request to the 3.15 branch. |
|
GH-160961 is a backport of this pull request to the 3.14 branch. |
asvetlov
added a commit
that referenced
this pull request
Oct 30, 2026
…t__ (GH-160957) (#160960) gh-137549: Handle BaseExceptionGroup in asyncio.Timeout.__aexit__ (GH-160957) asyncio.timeout() inserted TimeoutError into the context chain of sub-exceptions only for ExceptionGroup; do the same for BaseExceptionGroup. (cherry picked from commit a683f70) Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
asvetlov
added a commit
that referenced
this pull request
Oct 30, 2026
…t__ (GH-160957) (#160961) gh-137549: Handle BaseExceptionGroup in asyncio.Timeout.__aexit__ (GH-160957) asyncio.timeout() inserted TimeoutError into the context chain of sub-exceptions only for ExceptionGroup; do the same for BaseExceptionGroup. (cherry picked from commit a683f70) Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyncio.timeout()inserts aTimeoutErrorinto the context chain of the sub-exceptions of anExceptionGroup, but skippedBaseExceptionGroup. That happens, for example, when aTaskGrouptask raises aBaseExceptionsubclass other thanSystemExit/KeyboardInterruptduring cancellation; its sub-exception kept a bareCancelledErroras its__context__.The check now uses
BaseExceptionGroup(a superclass ofExceptionGroup, so existing behaviour is unchanged). Added a regression test mirroringtest_timeout_taskgroup.asyncio.Timeout.__aexit__does not handleBaseExceptionGroup#137549🤖 Generated with Claude Code