Skip to content

gh-161263: Skip MD5 algorithm challenge tests on FIPS #161264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sethmlarson merged 2 commits into from
Nov 4, 2026
Merged

gh-161263: Skip MD5 algorithm challenge tests on FIPS #161264

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9eace7e
gh-161263: Skip MD5 algorithm challenge tests on FIPS
sethmlarson Nov 3, 2026
2428022
Need to skip a few more
sethmlarson Nov 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added Lib/lib2to3/Grammar3.11.18.final.0.pickle
View file
Open in desktop
Binary file not shown.
Binary file added Lib/lib2to3/PatternGrammar3.11.18.final.0.pickle
View file
Open in desktop
Binary file not shown.
15 changes: 9 additions & 6 deletions Lib/test/test_urllib2.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,11 @@

support.requires_working_socket(module=True)

skip_libssl_fips_mode = unittest.skipIf(
support.is_libssl_fips_mode(),
"conservative skip due to OpenSSL FIPS mode possible algorithm nerfing",
)

# XXX
# Request
# CacheFTPHandler (hard to write)
Expand Down Expand Up @@ -1782,6 +1787,7 @@ def test_proxy_basic_auth(self):
"proxy.example.com:3128",
)

@skip_libssl_fips_mode # Uses MD5 algorithm in challenge
def test_proxy_digest_auth(self):
# gh-60299: ProxyDigestAuthHandler must look up credentials using
# the proxy's authority
Expand Down Expand Up @@ -1845,6 +1851,7 @@ def test_proxy_digest_auth_uri(self):
auth = http_handler.requests[1].get_header("Proxy-authorization")
self.assertIn('uri="%s"' % request_url, auth)

@skip_libssl_fips_mode # Uses MD5 algorithm in challenge
def test_digest_auth_uses_full_url(self):
# The non-proxy case must keep using the full request URL (not
# just the host) for the password lookup, so that sub-URI realm
Expand Down Expand Up @@ -1967,6 +1974,7 @@ def check_digest_auth(self, headers, realm):
self.assertIn('nonce="dcd98b7102dd2f0e8b11d0f600bfb0c093"', auth)
self.assertIn('opaque="5ccc069c403ebaf9f0171e9517f40e41"', auth)

@skip_libssl_fips_mode
def test_digest_auth_multiple_challenges(self):
realm = "digest@example.com"
digest = (f'Digest realm="{realm}", '
Expand Down Expand Up @@ -2032,6 +2040,7 @@ def test_digest_auth_parse_challenges(self):
[('Negotiate', 'Negotiate'), ('Bearer', 'Bearer abc=='),
('Digest', 'Digest realm="a"')])

@skip_libssl_fips_mode
def test_proxy_digest_auth_multiple_challenges(self):
realm = "digest@example.com"
digest = (f'Digest realm="{realm}", '
Expand Down Expand Up @@ -2355,12 +2364,6 @@ def test_parse_proxy(self):
self.assertRaises(ValueError, _parse_proxy, 'file:/ftp.example.com'),


skip_libssl_fips_mode = unittest.skipIf(
support.is_libssl_fips_mode(),
"conservative skip due to OpenSSL FIPS mode possible algorithm nerfing",
)


class TestDigestAuthAlgorithms(unittest.TestCase):
def setUp(self):
self.handler = AbstractDigestAuthHandler()
Expand Down
2 changes: 2 additions & 0 deletions Misc/NEWS.d/next/Tests/2026-11-03-13-12-50.gh-issue-161263.Voe8VM.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Skip tests which use MD5 algorithm for WWW-Authenticate challenges when
libssl is in FIPS mode.
Loading