Repository navigation
Conversation
sobolevn
added
needs backport to 3.14
Documentation build overview
27 files changed ·
|
methane
approved these changes
Nov 4, 2026
encukou
reviewed
Nov 4, 2026
Co-authored-by: Petr Viktorin <encukou@gmail.com>
sobolevn
commented
Nov 4, 2026
vstinner
reviewed
Nov 4, 2026
Co-authored-by: Victor Stinner <vstinner@python.org>
sobolevn
commented
Nov 4, 2026
vstinner
reviewed
Nov 4, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
I'm now confused. The PR doesn't seem to change the text anymore, it just reformats it. Did I miss something?
Member
Author
|
@vstinner it is still better, because now it is clear what "except ... doesn't fall back to the iterating over a sequence of key value pairs" part relates to :) |
vstinner
approved these changes
Nov 4, 2026
vstinner
left a comment
vstinner
left a comment
Member
There was a problem hiding this comment.
LGTM
@vstinner it is still better, because now it is clear what "except ... doesn't fall back to the iterating over a sequence of key value pairs" part relates to :)
Ok. But then maybe don't call this PR "Fix PyDict_Update docs", but something more like "Clarify PyDict_Update docs" instead.
sobolevn
changed the title
PyDict_Update docsPyDict_Update docs
sobolevn
commented
Nov 4, 2026
encukou
reviewed
Nov 5, 2026
Co-authored-by: Petr Viktorin <encukou@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PyDict_MergeandPyDict_Updatehave conflicting docs: both require.keysto exist #160669