Skip to content

gh-161336: fix host mismatch in the test_imaplib - #161349

Merged
vstinner merged 1 commit into
python:mainfrom
NekoAsakura:gh-161336/imaplib-timeout-host
Nov 5, 2026
Merged

gh-161336: fix host mismatch in the test_imaplib#161349
vstinner merged 1 commit into
python:mainfrom
NekoAsakura:gh-161336/imaplib-timeout-host

Conversation

@NekoAsakura

@NekoAsakura NekoAsakura commented Nov 4, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@NekoAsakura
NekoAsakura requested a review from a team as a code owner November 4, 2026 19:58
@bedevere-app bedevere-app Bot mentioned this pull request Nov 4, 2026
Closed
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Nov 4, 2026
StanFromIreland
StanFromIreland approved these changes Nov 4, 2026
View reviewed changes

@StanFromIreland StanFromIreland left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable, WDYT Victor?

vstinner
vstinner reviewed Nov 5, 2026
View reviewed changes
Comment thread Lib/test/test_imaplib.py Resolved
vstinner
vstinner approved these changes Nov 5, 2026
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@NekoAsakura's analysis makes sense: #161336 (comment).

@vstinner vstinner added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 5, 2026
@vstinner
vstinner merged commit 356e6e2 into python:main Nov 5, 2026
64 checks passed
@miss-islington-app

miss-islington-app Bot commented Nov 5, 2026

Copy link
Copy Markdown

Thanks @NekoAsakura for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Nov 5, 2026

Copy link
Copy Markdown

GH-161424 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 5, 2026
@bedevere-app

bedevere-app Bot commented Nov 5, 2026

Copy link
Copy Markdown

GH-161425 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 5, 2026
@vstinner

vstinner commented Nov 5, 2026

Copy link
Copy Markdown
Member

Merged. Thanks for the fix.

vstinner pushed a commit that referenced this pull request Nov 5, 2026
@miss-islington @NekoAsakura
[3.14] gh-161336: fix host mismatch in the test_imaplib (GH-161349) (…
ccadcf9 
…#161425)

gh-161336: fix host mismatch in the `test_imaplib` (GH-161349)
(cherry picked from commit 356e6e2)

Co-authored-by: Neko Asakura <neko.asakura@outlook.com>
vstinner pushed a commit that referenced this pull request Nov 5, 2026
@miss-islington @NekoAsakura
[3.15] gh-161336: fix host mismatch in the test_imaplib (GH-161349) (…
a475d58 
…#161424)

gh-161336: fix host mismatch in the `test_imaplib` (GH-161349)
(cherry picked from commit 356e6e2)

Co-authored-by: Neko Asakura <neko.asakura@outlook.com>
@NekoAsakura
NekoAsakura deleted the gh-161336/imaplib-timeout-host branch November 5, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NekoAsakura @vstinner @StanFromIreland