Skip to content

gh-161388: [tkinter] Fix crash on raising __str__ method passed to setvar - #161397

Merged
sobolevn merged 6 commits into
python:mainfrom
sobolevn:issue-161388
Nov 7, 2026
Merged

gh-161388: [tkinter] Fix crash on raising __str__ method passed to setvar#161397
sobolevn merged 6 commits into
python:mainfrom
sobolevn:issue-161388

Conversation

@sobolevn

@sobolevn sobolevn commented Nov 5, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot mentioned this pull request Nov 5, 2026
Closed
StanFromIreland
StanFromIreland approved these changes Nov 5, 2026
View reviewed changes
Comment thread Modules/_tkinter.c Resolved
sobolevn
sobolevn commented Nov 5, 2026
View reviewed changes
Comment thread Modules/_tkinter.c Resolved
Comment thread Modules/_tkinter.c Resolved
sobolevn
sobolevn commented Nov 5, 2026
View reviewed changes
Comment thread Modules/_tkinter.c Resolved
@sobolevn
sobolevn enabled auto-merge (squash) November 5, 2026 19:55
@sobolevn sobolevn added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 5, 2026
serhiy-storchaka
serhiy-storchaka reviewed Nov 5, 2026
View reviewed changes
Comment thread Lib/test/test_tcl.py Resolved
Comment thread Misc/NEWS.d/next/Library/2026-11-05-12-29-04.gh-issue-161388.s7ECT8.rst Resolved
@serhiy-storchaka

serhiy-storchaka commented Nov 5, 2026

Copy link
Copy Markdown
Member

The fix LGTM, I have comments for tests and NEWS.

@sobolevn
sobolevn disabled auto-merge November 5, 2026 20:08
serhiy-storchaka
serhiy-storchaka reviewed Nov 6, 2026
View reviewed changes
Comment thread Lib/test/test_tcl.py Resolved
Comment thread Lib/test/test_tcl.py Resolved
Comment thread Lib/test/test_tcl.py Resolved
serhiy-storchaka
serhiy-storchaka reviewed Nov 7, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If tk.setvar("name1", value) was set a Tcl variable, tk.getvar("name1", "name2") will fail for other reason. It is safer to use different names in all four cases, and check read immediately after an attempted write.

serhiy-storchaka
serhiy-storchaka approved these changes Nov 7, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. LGTM. 👍

@sobolevn
sobolevn enabled auto-merge (squash) November 7, 2026 10:10
@sobolevn

sobolevn commented Nov 7, 2026

Copy link
Copy Markdown
Member Author

Thank you for the reviews! 👍

@sobolevn
sobolevn merged commit 6026791 into python:main Nov 7, 2026
96 of 98 checks passed
@miss-islington-app

miss-islington-app Bot commented Nov 7, 2026

Copy link
Copy Markdown

Thanks @sobolevn for the PR 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@miss-islington-app

miss-islington-app Bot commented Nov 7, 2026

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.15 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 6026791c977a1df2ff8a427aad294388992ae078 3.15

@miss-islington-app

miss-islington-app Bot commented Nov 7, 2026

Copy link
Copy Markdown

Sorry, @sobolevn, I could not cleanly backport this to 3.14 due to a conflict.

Please backport manually with cherry_picker, see the devguide for more information.

cherry_picker 6026791c977a1df2ff8a427aad294388992ae078 3.14

@bedevere-app

bedevere-app Bot commented Nov 7, 2026

Copy link
Copy Markdown

GH-161550 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 7, 2026
@bedevere-app

bedevere-app Bot commented Nov 7, 2026

Copy link
Copy Markdown

GH-161551 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 7, 2026
sobolevn added a commit that referenced this pull request Nov 7, 2026
@sobolevn
[3.15] gh-161388: [tkinter] Fix crash on raising __str__ method pas…
a03a696 
…sed to `setvar` (GH-161397) (#161550)

(cherry picked from commit 6026791)

Co-authored-by: sobolevn <mail@sobolevn.me>
sobolevn added a commit that referenced this pull request Nov 7, 2026
@sobolevn
[3.14] gh-161388: [tkinter] Fix crash on raising __str__ method pas…
f3eb3cc 
…sed to `setvar` (GH-161397) (#161551)

(cherry picked from commit 6026791)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@StanFromIreland StanFromIreland StanFromIreland approved these changes
@gpshead gpshead Awaiting requested review from gpshead

Assignees

@sobolevn sobolevn

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sobolevn @serhiy-storchaka @StanFromIreland