Skip to content

gh-161415: Remove nonexistent related help topics in pydoc - #161417

Merged
sobolevn merged 4 commits into
python:mainfrom
andresdelfino:gh-161415-pydoc-related-topics
Nov 7, 2026
Merged

sobolevn merged 4 commits into
python:mainfrom
andresdelfino:gh-161415-pydoc-related-topics

Conversation

@andresdelfino

@andresdelfino andresdelfino commented Nov 5, 2026 •

Copy link
Copy Markdown
Contributor

help('TYPES') listed FILES and help('UNICODE') listed unicode under "Related help topics", but help() finds no entry for either. The FILES topic was removed from Helper.topics in 3.4 (gh-63118) while the cross-reference from TYPES was kept, and unicode is the Python 2 built-in type. This removes both.

The new test runs help() on every related topic listed by the help() topics and keywords, and on the target of every alias entry (such as 'PACKAGES': 'import'), and checks that none of them prints "No help entry found". Without the fix it fails for exactly these two entries.

🤖 Generated with Claude Code

The TYPES topic listed FILES, which was removed from Helper.topics in
Python 3.4, and the UNICODE topic listed unicode, the Python 2 built-in
type. help() finds no entry for either of them.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comment thread Lib/test/test_pydoc/test_pydoc.py Resolved
Comment thread Lib/test/test_pydoc/test_pydoc.py Resolved
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sobolevn sobolevn added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 7, 2026
@sobolevn

sobolevn commented Nov 7, 2026

Copy link
Copy Markdown
Member

Thank you!

@sobolevn
sobolevn enabled auto-merge (squash) November 7, 2026 08:10
@sobolevn
sobolevn merged commit 301643a into python:main Nov 7, 2026
105 of 107 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @andresdelfino for the PR, and @sobolevn for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Nov 7, 2026

Copy link
Copy Markdown

GH-161541 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 7, 2026
@bedevere-app

bedevere-app Bot commented Nov 7, 2026

Copy link
Copy Markdown

GH-161542 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 7, 2026
sobolevn pushed a commit that referenced this pull request Nov 7, 2026
…H-161417) (#161542)

gh-161415: Remove nonexistent related help topics in `pydoc` (GH-161417)

The TYPES topic listed FILES, which was removed from Helper.topics in
Python 3.4, and the UNICODE topic listed unicode, the Python 2 built-in
type. help() finds no entry for either of them.
(cherry picked from commit 301643a)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
sobolevn pushed a commit that referenced this pull request Nov 7, 2026
…H-161417) (#161541)

gh-161415: Remove nonexistent related help topics in `pydoc` (GH-161417)

The TYPES topic listed FILES, which was removed from Helper.topics in
Python 3.4, and the UNICODE topic listed unicode, the Python 2 built-in
type. help() finds no entry for either of them.
(cherry picked from commit 301643a)

Co-authored-by: Andrés Delfino <adelfino@gmail.com>
@andresdelfino
andresdelfino deleted the gh-161415-pydoc-related-topics branch November 7, 2026 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants