Repository navigation
gh-142782: compare zoneinfo strong cache keys by string contents - #161463
Merged
StanFromIreland merged 3 commits intoNov 6, 2026
Merged
StanFromIreland merged 3 commits into
StanFromIreland merged 3 commits into
Conversation
tonghuaroot
requested review from
StanFromIreland and
pganssle
as code owners
November 6, 2026 07:03
StanFromIreland
approved these changes
Nov 6, 2026
StanFromIreland
enabled auto-merge (squash)
November 6, 2026 16:25
StanFromIreland
added
needs backport to 3.14
Member
|
Backporting, as discussed in #159441. |
|
Thanks @tonghuaroot for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15. |
|
GH-161505 is a backport of this pull request to the 3.15 branch. |
|
GH-161506 is a backport of this pull request to the 3.14 branch. |
StanFromIreland
added a commit
that referenced
this pull request
Nov 6, 2026
StanFromIreland
added a commit
that referenced
this pull request
Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
compare zoneinfo strong cache keys by their unicode contents. this avoids calling custom equality methods that can mutate the cache during lookup.
the original reproducer and the full zoneinfo test suite pass with this change.
zone_from_strong_cachevia re-entrantZoneInfo.clear_cache()from key__eq__#142782