Skip to content

gh-161477: Fix single-element tuple in idlelib redirector __repr__ - #161481

Merged
terryjreedy merged 4 commits into
python:mainfrom
PavlNekrasov:fix-single-element-tuple
Nov 6, 2026
Merged

terryjreedy merged 4 commits into
python:mainfrom
PavlNekrasov:fix-single-element-tuple

Conversation

@PavlNekrasov

@PavlNekrasov PavlNekrasov commented Nov 6, 2026 •

Copy link
Copy Markdown
Contributor

Result is mangled repr(). Extremely unlikely to be seen by IDLE users, but idlelib maintainers might if internal error.

Drop the stray comma in two __repr__ f-strings so repr() does not
format a one-element tuple.
@bedevere-app

bedevere-app Bot commented Nov 6, 2026

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@StanFromIreland StanFromIreland changed the title Fix single-element tuple in idlelib redirector __repr__ gh-161477: Fix single-element tuple in idlelib redirector __repr__ Nov 6, 2026

@sobolevn sobolevn left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a user-facing bug, please add a NEWS entry. Other than that - LGTM :)

@sobolevn sobolevn added needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes labels Nov 6, 2026
@terryjreedy
terryjreedy merged commit 149562e into python:main Nov 6, 2026
53 checks passed
@miss-islington-app

Copy link
Copy Markdown

Thanks @PavlNekrasov for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14, 3.15.
🐍🍒⛏🤖

@bedevere-app

bedevere-app Bot commented Nov 6, 2026

Copy link
Copy Markdown

GH-161521 is a backport of this pull request to the 3.15 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.15 bugs and security fixes label Nov 6, 2026
@bedevere-app

bedevere-app Bot commented Nov 6, 2026

Copy link
Copy Markdown

GH-161522 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed the needs backport to 3.14 bugs and security fixes label Nov 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants