Automatically credit remediation developers and reviewers - #61
Open
sethmlarson wants to merge 6 commits into
Open
Automatically credit remediation developers and reviewers#61sethmlarson wants to merge 6 commits into
sethmlarson wants to merge 6 commits into
Conversation
StanFromIreland
left a comment
StanFromIreland
left a comment
Member
There was a problem hiding this comment.
Can you also please update the flow chart in the README for this, TiA!
StanFromIreland
approved these changes
Aug 21, 2026
StanFromIreland
left a comment
StanFromIreland
left a comment
Member
There was a problem hiding this comment.
Last few nits, otherwise looks good. If you prefer we can leave updating the documentation (a.k.a. README) to a follow up, but it would be nice to get it done now.
|
|
||
| for review in reviews: | ||
| review_login = review["user"]["login"] | ||
| if review_login == pull_request_author: |
Member
There was a problem hiding this comment.
Hmm, this is a little bit of an edge case, but if someone opens a PR, and then reviews an alternative PR by a different author, the credit type is dependant on the order in which the PRs are processed. Do we care? Not really, it's hard to judge which one will be more correct, I think we can manually fix it up if this occurs.
Co-authored-by: Stan Ulbrych <stan@python.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bot can automatically credit people who participate in creating a patch or reviewing the patch privately. Does not override credits that already exist for an individual.