Include ARM64 package in fallback index - #399
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may need to lead to a future re-think of how to include bundled runtimes, but now that we have two potential offline defaults we either need to let ARM64 OS default to x64 builds (which would work okay-ish) or start producing two packages and make users choose the right one ahead of time (also barely okay-ish).
In the meantime, having both packages seems like the least bad option right now. Most of the extra size is unfortunately two (zipped) copies of the docs, but until we decide that the docs don't need to be installed at all, that's unavoidable.