Repository navigation
Fix weblogin v2 logic with totp enabled - #400
Merged
Merged
Conversation
The logic did not wait for the confirmation of the popup in the app so it could never complete authentication
Contributor
Author
|
This would probably close #393 |
RealCLanger
approved these changes
Oct 7, 2026
RealCLanger
left a comment
RealCLanger
left a comment
Collaborator
There was a problem hiding this comment.
Looking at the code, this makes sense. I can not test it with TOTP but as you report that it helps, let's merge this and wait for feedback.
Thanks for the contribution.
After posting the TOTP code, the flow now also polls the login process for final in-app confirmation, matching the production code.
Collaborator
|
There were test failures, added test modifications |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logic did not wait for the confirmation of the popup in the app so it could never complete authentication
I'm not sure if that is a change in the app but there is a popup that needs to be confirmed for the login to work even with the correct TOTP code. This fixes it, although I'm not 100% sure if the logic is correct for every possibility.
Resume of session also works.