Skip to content

Fix details command after instrumentSuitability removal - #402

Merged
RealCLanger merged 1 commit into
pytr-org:masterfrom
TiloHeidasch:fix-details-instrument-suitability
Oct 7, 2026
Merged

RealCLanger merged 1 commit into
pytr-org:masterfrom
TiloHeidasch:fix-details-instrument-suitability

Conversation

@TiloHeidasch

Copy link
Copy Markdown
Contributor

Closes #401

Trade Republic now rejects the instrumentSuitability WebSocket topic with BAD_SUBSCRIPTION_TYPE. The details output does not consume this response, so this removes the obsolete subscription and completes after the five remaining supported responses.

Verification:

  • Reproduced the upstream rejection with an authenticated session.
  • Verified the revised loop closes normally after five responses.
  • Verified pytr details IE0000MR4GH9 retrieves instrument details against Trade Republic after the change.

@RealCLanger RealCLanger left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct, thanks for the contribution.

I also have some open work on the details command which includes this. But it's a good thing to merge this since my change is not quite ready yet.

@RealCLanger
RealCLanger merged commit 353839d into pytr-org:master Oct 7, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix details command after instrumentSuitability subscription removal

2 participants