Repository navigation
Fix details command after instrumentSuitability removal - #402
Merged
RealCLanger merged 1 commit intoOct 7, 2026
Merged
Conversation
RealCLanger
approved these changes
Oct 7, 2026
RealCLanger
left a comment
Collaborator
There was a problem hiding this comment.
Looks correct, thanks for the contribution.
I also have some open work on the details command which includes this. But it's a good thing to merge this since my change is not quite ready yet.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #401
Trade Republic now rejects the
instrumentSuitabilityWebSocket topic withBAD_SUBSCRIPTION_TYPE. The details output does not consume this response, so this removes the obsolete subscription and completes after the five remaining supported responses.Verification:
pytr details IE0000MR4GH9retrieves instrument details against Trade Republic after the change.