Skip to content

feat(ipc): expose native fullscreen state in workspace snapshots - #292

Merged
qeude merged 2 commits into
qeude:mainfrom
marvelph:feat/workspace-native-fullscreen
Nov 15, 2026
Merged

qeude merged 2 commits into
qeude:mainfrom
marvelph:feat/workspace-native-fullscreen

Conversation

@marvelph

@marvelph marvelph commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

What changes

Placeholders for full-screen windows cannot be distinguished from regular windows in workspace change notifications.
A Boolean value named nativeFullscreen
will be added to each window so that it can be used by the SketchyBar integration.

This field is available in the workspace snapshots returned by workspaceChanged, list-workspaces --json, and
subscribe.

How I verified it

  • make verify

Confirmed nativeFullscreen is true for a fullscreen placeholder and false for regular windows in list-workspaces --json.

Note

Add nativeFullscreen flag to workspace window snapshots

  • Adds a non-optional nativeFullscreen Boolean to WorkspaceWindowSnapshot in IPC.swift, populated by makeWorkspaceStateSnapshot from a new nativeFullscreenWindowIDs parameter (defaults to an empty set).
  • Daemon.currentWorkspaceState in DaemonWorkspaceIntegration.swift passes the daemon's native fullscreen window IDs into the snapshot.
  • Documents the new field in CONFIGURATION.md and the SketchyBar README.md, noting native fullscreen windows are represented as tiled windows in a placeholder column.
  • Behavioral Change: decoding a WorkspaceWindowSnapshot now requires the nativeFullscreen field, so older encoded snapshots without it fail to decode.

Macroscope summarized 75c1248.

@macroscopeapp

macroscopeapp Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — This adds native fullscreen state to workspace JSON snapshots without changing window management behavior. Human review is required because the PR author is not the repository’s designated auto-approvable author.

You can add or adjust custom eligibility rules. Learn more.

@qeude qeude added the macroscope-review Request a Macroscope review label Nov 15, 2026

@qeude qeude left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I added the field to the SketchyBar guide and noted how a floating window in native fullscreen is reported.

@qeude
qeude merged commit a8a0eac into qeude:main Nov 15, 2026
4 checks passed
@marvelph

Copy link
Copy Markdown
Contributor Author

@qeude
Thank you for reviewing my pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Request a Macroscope review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants