Repository navigation
feat(ipc): expose native fullscreen state in workspace snapshots - #292
Merged
Merged
Conversation
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — This adds native fullscreen state to workspace JSON snapshots without changing window management behavior. Human review is required because the PR author is not the repository’s designated auto-approvable author. You can add or adjust custom eligibility rules. Learn more. |
qeude
approved these changes
Nov 15, 2026
qeude
left a comment
Owner
There was a problem hiding this comment.
LGTM, thanks! I added the field to the SketchyBar guide and noted how a floating window in native fullscreen is reported.
Contributor
Author
|
@qeude |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
Placeholders for full-screen windows cannot be distinguished from regular windows in workspace change notifications.
A Boolean value named
nativeFullscreenwill be added to each window so that it can be used by the SketchyBar integration.
This field is available in the workspace snapshots returned by
workspaceChanged,list-workspaces --json, andsubscribe.How I verified it
make verifyConfirmed
nativeFullscreenistruefor a fullscreen placeholder andfalsefor regular windows inlist-workspaces --json.Note
Add
nativeFullscreenflag to workspace window snapshotsnativeFullscreenBoolean toWorkspaceWindowSnapshotin IPC.swift, populated bymakeWorkspaceStateSnapshotfrom a newnativeFullscreenWindowIDsparameter (defaults to an empty set).Daemon.currentWorkspaceStatein DaemonWorkspaceIntegration.swift passes the daemon's native fullscreen window IDs into the snapshot.WorkspaceWindowSnapshotnow requires thenativeFullscreenfield, so older encoded snapshots without it fail to decode.Macroscope summarized 75c1248.