Skip to content

fix(overview): show the native fullscreen placeholder where the strip does - #293

Merged
qeude merged 1 commit into
mainfrom
fix/overview-fullscreen-placeholder-position
Nov 15, 2026
Merged

qeude merged 1 commit into
mainfrom
fix/overview-fullscreen-placeholder-position

Conversation

@qeude

@qeude qeude commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Closes #287

Summary

The Overview rebuilt each native fullscreen window's pre-fullscreen slot, so its card stayed in place while the strip shows the placeholder at the end. The Overview now reads the strip as it is.

 makeOverviewSnapshot
-  monitors: logicalOverviewMonitors(state)   # reinsert fullscreen windows at their saved slot
+  monitors: state.monitors                   # same columns as the strip

logicalOverviewMonitors is deleted (−110 lines). The saved slot in nativeFullscreenTiledPlacements is untouched, so leaving fullscreen still returns the window to its original column. Overview drop targets now also index the same columns that applyOverviewDrop resolves them against.

Evidence

DaemonOverviewSnapshotTests.overviewShowsFullscreenPlaceholderWhereTheStripDoes: three windows, window 1 enters native fullscreen.

  • Before (main): strip [3] [2] [1], Overview [1] [3] [2] → overview == strip fails
  • After: Overview [3] [2] [1] → passes; make verify passes

The old runtime test that asserted the restored-slot projection is removed with the function.

Real daemon (defi-e2e VM, Screen Recording granted): W1 W2 W3 on a fresh workspace, W2 enters native fullscreen, the strip becomes W1 W3 [W2 placeholder], then the Overview opens.

  • main: Overview cards W1 W2 W3, the fullscreen card still between W1 and W3
  • this branch: Overview cards W1 W3 W2, matching the strip

Proved with the failing-then-passing test above and a before/after recording of both builds in the VM.

Merge Danger

Door: two-way

Blast Radius: Overview

Only how the Overview orders columns that hold a native fullscreen window changes; the strip, fullscreen exit, and parking are unchanged. A fullscreen window that was stacked now shows as its own column at the end, as in the strip. Desktop E2E tests and Computer Use on the maintainer's Mac were not run; the VM recording covers the changed Overview path.

Reviewed with review-loop: 1 round with claude-opus-5-5. Verdict: approved

Note

Show native fullscreen placeholders in overview where the strip does

  • Daemon.makeOverviewSnapshot now builds snapshots from runtime monitors directly instead of the logical overview projection. This keeps native fullscreen window placeholders in the same overview columns the strip shows.
  • Deletes logicalOverviewMonitors in OverviewRuntime.swift and the private OverviewPlacementGroup, along with their tests.
  • Adds a test in DaemonOverviewSnapshotTests.swift that reconciles a native fullscreen window and compares strip columns to snapshot columns.
  • Behavioral Change: overview snapshots now use runtime workspace/monitor state, so any consumers of the removed logical projection (full workspace copy, scroll offsets, selection) must use runtime state instead.

Macroscope summarized d416e95.

@github-actions github-actions Bot added the macroscope-review Request a Macroscope review label Nov 15, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — Overview fullscreen placeholders now follow the same column ordering as the strip. The PR also removes an existing runtime test, which requires human review even with the new snapshot regression test.

Notes:

  • Macroscope's correctness review did not run, so approvability was decided on eligibility alone.

No code changes detected at d416e95. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

… does

The Overview rebuilt each window's pre-fullscreen slot, so the card stayed
in place while the strip moved the placeholder to its end. Read the strip
directly; the saved slot still restores the window on exit.

Closes #287
@qeude
qeude force-pushed the fix/overview-fullscreen-placeholder-position branch from fdcce8f to d416e95 Compare November 15, 2026 17:53
@qeude
qeude merged commit 9831188 into main Nov 15, 2026
4 checks passed
@qeude
qeude deleted the fix/overview-fullscreen-placeholder-position branch November 15, 2026 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Request a Macroscope review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

In Overview mode, the full-screen placeholder appears in the wrong position

1 participant