Repository navigation
fix(input): let swipes reach the native fullscreen placeholder - #294
Merged
Merged
Conversation
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — Swipes can now reach and animate native fullscreen placeholders without switching to their Spaces. The change removes the old exclusion test and adds daemon coverage for the new behavior; retiring that test requires human review. No code changes detected at You can add or adjust custom eligibility rules. Learn more. |
The placeholder panel was never on the overlay: during a swipe or an animated move it vanished under the backdrop and popped back once the motion landed. It now travels as an overlay window drawn from the same picture as the panel, built from the daemon's own window state, since macOS lists a window on its fullscreen Space only intermittently.
Ordered in while its window's fullscreen Space was active, the panel stayed on that Space and never showed on the desktop strip. It now joins every desktop Space and no fullscreen one, like the window borders.
qeude
force-pushed
the
fix/swipe-reaches-fullscreen-placeholder
branch
from
November 15, 2026 17:43
b2a6c74 to
9fb197f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #288.
Proved with a failing-then-passing
ScrollPanTestscase and before/after VM recordings of the real daemon.Why
Key presses already reach the native fullscreen placeholder at the end of the strip:
synchronizeScrollOffsetscomputes scroll targets over every column, placeholder included. The sideways swipe (#227) excluded fullscreen columns from its bounds and landings, so it stopped one column short.What
nativeFullscreenPlaceholderImage), so the handoff doesn't show. Its app and title come from the daemon's window state, because macOS lists a window on its fullscreen Space only intermittently and the snapshot can't be relied on.scrollGestureSnapandscrollGestureFreeRestlose theirexcludingWindowIDsparameter, which no caller needs now. Drag-edge scrolling and the vertical swipe's neighbour layout keep their exclusion: they place real frames.Proof
ScrollPanTestscase drives a realDaemonthroughhandleScrollGesture. Four half-width columns with the last one in native fullscreen, and a swipe from column 3 released half a screen to the left. Onmainit lands on column 2 at offset 0.5 and queues a focus; with the fix it lands on the placeholder at offset 1 and queues no focus.A swipe never lands on a native fullscreen column, which asserted the old behaviour.defi-e2eVM with the real daemon, synthetic two-finger swipes and arrow keys. With the previous build the placeholder disappears for the whole swipe. With this one it slides in with the strip. A debug trace confirmed the cause: at swipe start the fullscreen window was missing from the snapshot in every case.onscreen 1). Before the Space fix, the same dump showed it at the right frame butonscreen 0.make verifypasses.Not covered
Reviewed with review-loop: 1 round with claude-opus-5-5 on medium. Verdict: approved
Note
Let scroll gestures land on native fullscreen placeholders in the workspace ribbon
scrollGestureSnapandscrollGestureFreeRestin WorkspaceScrolling.swift, so swipe targets now include native fullscreen columnsDaemon.applyCurrentLayoutin DaemonDesktop.swift collects native fullscreen ribbon frames and passes placeholder metadata to the platform;MonitorLayoutPlanstores these frames separately from visible-placeholder assignmentsnativeFullscreenProxiesin MacOSPlatform.swift renders cached card images, and RibbonProxyRenderer.swift styles image-backed proxies without icon, border, or shadowDaemon.endScrollPanskips animated focus when the settled window is native fullscreen; the placeholder panel now joins all Spaces and uses layer-backed image renderingisOutOfLayoutin WorkspaceScrolling.swift is removed and its callers no longer filter excluded columns; the old exclusion test was deleted from WorkspaceScrollingTests.swiftMacroscope summarized 9fb197f.