Skip to content

fix(input): let swipes reach the native fullscreen placeholder - #294

Merged
qeude merged 3 commits into
mainfrom
fix/swipe-reaches-fullscreen-placeholder
Nov 15, 2026
Merged

qeude merged 3 commits into
mainfrom
fix/swipe-reaches-fullscreen-placeholder

Conversation

@qeude

@qeude qeude commented Nov 15, 2026 •

Copy link
Copy Markdown
Owner

Closes #288.

Proved with a failing-then-passing ScrollPanTests case and before/after VM recordings of the real daemon.

Why

Key presses already reach the native fullscreen placeholder at the end of the strip: synchronizeScrollOffsets computes scroll targets over every column, placeholder included. The sideways swipe (#227) excluded fullscreen columns from its bounds and landings, so it stopped one column short.

What

  • The swipe's bounds, snap and free rest count the placeholder column like any other. Fullscreen columns are always trailing, so the windows before them keep the same positions in both layouts.
  • A swipe landing on the placeholder only selects it and queues no focus write, because focusing the fullscreen window would switch to its Space. This is the direction Activate the selected fullscreen placeholder with Enter #290 asks for; keyboard selection still switches until Activate the selected fullscreen placeholder with Enter #290 changes it.
  • The placeholder now travels with the strip on the overlay, like a window, during swipes and animated moves. Before, the panel was never on the overlay: it vanished under the backdrop for the whole motion and popped back once it landed. The panel and its overlay copy draw the same picture (nativeFullscreenPlaceholderImage), so the handoff doesn't show. Its app and title come from the daemon's window state, because macOS lists a window on its fullscreen Space only intermittently and the snapshot can't be relied on.
  • The placeholder panel joins every desktop Space and no fullscreen Space, like the window borders. Before, it could be ordered in while the fullscreen Space was active and stay there, so it never showed on the strip, even at rest.
  • scrollGestureSnap and scrollGestureFreeRest lose their excludingWindowIDs parameter, which no caller needs now. Drag-edge scrolling and the vertical swipe's neighbour layout keep their exclusion: they place real frames.

Proof

  • New ScrollPanTests case drives a real Daemon through handleScrollGesture. Four half-width columns with the last one in native fullscreen, and a swipe from column 3 released half a screen to the left. On main it lands on column 2 at offset 0.5 and queues a focus; with the fix it lands on the placeholder at offset 1 and queues no focus.
  • Removed the core test A swipe never lands on a native fullscreen column, which asserted the old behaviour.
  • Recorded in the defi-e2e VM with the real daemon, synthetic two-finger swipes and arrow keys. With the previous build the placeholder disappears for the whole swipe. With this one it slides in with the strip. A debug trace confirmed the cause: at swipe start the fullscreen window was missing from the snapshot in every case.
  • A VM window dump showed the panel on screen at rest and after each swipe (onscreen 1). Before the Space fix, the same dump showed it at the right frame but onscreen 0.
  • make verify passes.

Not covered

  • No installed-build or replayed real-trackpad validation: no install was requested. The VM recordings use synthetic swipes.
  • Surfaces: only trackpad swipes are affected. Hotkey, CLI and Overview paths are unchanged, and there is no Settings or config change. The two-display lane didn't run.

Reviewed with review-loop: 1 round with claude-opus-5-5 on medium. Verdict: approved

Note

Let scroll gestures land on native fullscreen placeholders in the workspace ribbon

  • Removes the native-fullscreen exclusion set from scrollGestureSnap and scrollGestureFreeRest in WorkspaceScrolling.swift, so swipe targets now include native fullscreen columns
  • Daemon.applyCurrentLayout in DaemonDesktop.swift collects native fullscreen ribbon frames and passes placeholder metadata to the platform; MonitorLayoutPlan stores these frames separately from visible-placeholder assignments
  • Adds image-backed ribbon proxies for native fullscreen placeholders: nativeFullscreenProxies in MacOSPlatform.swift renders cached card images, and RibbonProxyRenderer.swift styles image-backed proxies without icon, border, or shadow
  • Daemon.endScrollPan skips animated focus when the settled window is native fullscreen; the placeholder panel now joins all Spaces and uses layer-backed image rendering
  • Risk: isOutOfLayout in WorkspaceScrolling.swift is removed and its callers no longer filter excluded columns; the old exclusion test was deleted from WorkspaceScrollingTests.swift

Macroscope summarized 9fb197f.

@github-actions github-actions Bot added the macroscope-review Request a Macroscope review label Nov 15, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 15, 2026 •

Copy link
Copy Markdown

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — Swipes can now reach and animate native fullscreen placeholders without switching to their Spaces. The change removes the old exclusion test and adds daemon coverage for the new behavior; retiring that test requires human review.

No code changes detected at 9fb197f. Prior analysis still applies.

You can add or adjust custom eligibility rules. Learn more.

The placeholder panel was never on the overlay: during a swipe or an animated
move it vanished under the backdrop and popped back once the motion landed.
It now travels as an overlay window drawn from the same picture as the panel,
built from the daemon's own window state, since macOS lists a window on its
fullscreen Space only intermittently.
Ordered in while its window's fullscreen Space was active, the panel stayed on
that Space and never showed on the desktop strip. It now joins every desktop
Space and no fullscreen one, like the window borders.
@qeude
qeude force-pushed the fix/swipe-reaches-fullscreen-placeholder branch from b2a6c74 to 9fb197f Compare November 15, 2026 17:43
@qeude
qeude merged commit 312432f into main Nov 15, 2026
4 checks passed
@qeude
qeude deleted the fix/swipe-reaches-fullscreen-placeholder branch November 15, 2026 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Request a Macroscope review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

I can't reach the full-screen placeholder using a swipe gesture

1 participant