Skip to content

feat(fullscreen): select placeholders without switching Spaces - #300

Merged
qeude merged 3 commits into
mainfrom
feat/fullscreen-placeholder-explicit-activation
Nov 16, 2026
Merged

qeude merged 3 commits into
mainfrom
feat/fullscreen-placeholder-explicit-activation

Conversation

@qeude

@qeude qeude commented Nov 16, 2026 •

Copy link
Copy Markdown
Owner

Closes #290.

Summary

Selecting a native fullscreen window's placeholder no longer switches to its Space. The placeholder takes the keyboard, and Return opens it.

 select placeholder (strip navigation, workspace switch, focus-monitor, Overview exit)
-  focus window → macOS switches to its fullscreen Space
+  placeholder panel becomes key, the user stays in the strip
+  Return on it → switch to its Space
+  from inside a fullscreen Space → the desktop anchor panel switches back first

 explicit activation (switches Spaces, as before or new)
+  activate-window (new, default mod-return)
   focus-window-id, focus-window-previous, recent windows, Overview choice
   Command-Tab, Dock (native, unchanged)
  • MacOSPlatform.focus writes native focus to a fullscreen window only when nativeFullscreenActivationWindowID names it. The daemon sets that on the explicit paths above.
  • NativeFullscreenPlaceholderManager:
    • The selected panel takes the keyboard. Return calls the activation handler, and other keys are dropped.
    • A 1×1 anchor panel per monitor, ordered once on the desktop Space, brings the user back from a fullscreen Space.
    • Placeholder panels are never ordered in while their monitor shows a fullscreen Space. They join only the desktop Space (fix(input): let swipes reach the native fullscreen placeholder #294's canJoinAllSpaces drew them over fullscreen apps in the VM).
  • The overlay skips proxies, and the background capture skips the display, while a monitor shows a fullscreen Space. The wallpaper captured there was the fullscreen app, which showed as a leftover image while scrolling the desktop.
  • A fullscreen Space counts as on screen when its window or a window of the same process covers the display, since some apps show fullscreen content in another window. Each anchor uses the screen of its placeholder's monitor.
  • The selected placeholder card reads "Press Return to open".
  • activate-window is refused while the Overview is open: Enter there already activates.

Evidence

Validated in the defi-e2e VM with the staged build, three runs at normal speed. Each run uses one normal window and three fullscreen fixture windows (A, B, C): mod-→ across all three, type 123, Return, mod-←, Return, then mod-← back to the normal window. Captures run continuously.

  • Before: the first focus of a placeholder switched to its Space, so crossing the strip jumped from Space to Space. Scrolling back on the desktop showed the fullscreen app's image in the wallpaper.
  • After: mod-→ stays on the desktop (front=Defi). The keys typed while a placeholder is selected never reach the normal window (normale text: 0). Each Return opens the selected window's Space. Each mod-← from a fullscreen Space returns to the desktop with the next placeholder selected. No frame shows the fullscreen image, or a placeholder card, outside the desktop.

make verify passes. New unit cases cover the activation flag in MacOSPlatform.focus, the drawn placeholder card, suppression in the manager, activate-window parsing, the default binding, the cheatsheet, and the Overview refusal.

Not covered: two displays, trackpad swipes, Mission Control.

Merge Danger

Door: two-way

Revert restores Space switching on selection. No stored state or config migration. mod-return becomes a new default binding.

Blast Radius: fullscreen

Only users with windows in native macOS fullscreen. Risk: after a Space switch macOS can return the keyboard late. The panel retries for 2 s, and Return on the anchor still opens the selected placeholder.

Reviewed with review-loop: 3 rounds with claude-opus-5-5. Verdict: approved

Selecting a native fullscreen window's placeholder keeps the user in the
strip. The placeholder takes the keyboard and Return switches to its
Space, as do activate-window (mod-return), focus-window-id, recent
windows and the Overview. A desktop anchor panel brings the user back
from a fullscreen Space when they navigate away.

Placeholder panels join only the desktop Space: on all Spaces they drew
over fullscreen apps. The background capture skips displays showing a
fullscreen Space, whose image otherwise appeared while scrolling.

Closes #290.
@github-actions github-actions Bot added the macroscope-review Request a Macroscope review label Nov 16, 2026
@macroscopeapp

macroscopeapp Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

Approvability

Verdict: Needs Human Approval

Macroscope's review found this PR requires human approval — Fullscreen placeholders become selectable without switching Spaces, with Return used for activation. The new default mod-return shortcut requires human review of the keyboard behavior change.

You can add or adjust custom eligibility rules. Learn more.

Some apps show their fullscreen content in a window other than the
managed one. A window of the same process covering a whole display now
counts as that fullscreen Space being on screen.
A placeholder slot can lie mostly on another display; the anchor now
takes the screen of the placeholder's monitor instead of the panel's.
@qeude
qeude merged commit 66ac6ec into main Nov 16, 2026
4 checks passed
@qeude
qeude deleted the feat/fullscreen-placeholder-explicit-activation branch November 16, 2026 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

macroscope-review Request a Macroscope review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Activate the selected fullscreen placeholder with Enter

1 participant