Repository navigation
feat(fullscreen): select placeholders without switching Spaces - #300
Merged
Merged
Conversation
Selecting a native fullscreen window's placeholder keeps the user in the strip. The placeholder takes the keyboard and Return switches to its Space, as do activate-window (mod-return), focus-window-id, recent windows and the Overview. A desktop anchor panel brings the user back from a fullscreen Space when they navigate away. Placeholder panels join only the desktop Space: on all Spaces they drew over fullscreen apps. The background capture skips displays showing a fullscreen Space, whose image otherwise appeared while scrolling. Closes #290.
ApprovabilityVerdict: Needs Human Approval Macroscope's review found this PR requires human approval — Fullscreen placeholders become selectable without switching Spaces, with Return used for activation. The new default mod-return shortcut requires human review of the keyboard behavior change. You can add or adjust custom eligibility rules. Learn more. |
Some apps show their fullscreen content in a window other than the managed one. A window of the same process covering a whole display now counts as that fullscreen Space being on screen.
A placeholder slot can lie mostly on another display; the anchor now takes the screen of the placeholder's monitor instead of the panel's.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #290.
Summary
Selecting a native fullscreen window's placeholder no longer switches to its Space. The placeholder takes the keyboard, and Return opens it.
MacOSPlatform.focuswrites native focus to a fullscreen window only whennativeFullscreenActivationWindowIDnames it. The daemon sets that on the explicit paths above.NativeFullscreenPlaceholderManager:canJoinAllSpacesdrew them over fullscreen apps in the VM).activate-windowis refused while the Overview is open: Enter there already activates.Evidence
Validated in the
defi-e2eVM with the staged build, three runs at normal speed. Each run uses one normal window and three fullscreen fixture windows (A, B, C): mod-→ across all three, type123, Return, mod-←, Return, then mod-← back to the normal window. Captures run continuously.front=Defi). The keys typed while a placeholder is selected never reach the normal window (normale text: 0). Each Return opens the selected window's Space. Each mod-← from a fullscreen Space returns to the desktop with the next placeholder selected. No frame shows the fullscreen image, or a placeholder card, outside the desktop.make verifypasses. New unit cases cover the activation flag inMacOSPlatform.focus, the drawn placeholder card, suppression in the manager,activate-windowparsing, the default binding, the cheatsheet, and the Overview refusal.Not covered: two displays, trackpad swipes, Mission Control.
Merge Danger
Door: two-way
Revert restores Space switching on selection. No stored state or config migration.
mod-returnbecomes a new default binding.Blast Radius: fullscreen
Only users with windows in native macOS fullscreen. Risk: after a Space switch macOS can return the keyboard late. The panel retries for 2 s, and Return on the anchor still opens the selected placeholder.
Reviewed with review-loop: 3 rounds with claude-opus-5-5. Verdict: approved