Skip to content

QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays - #1862

Merged
Komal Bajaj (Komal-Bajaj) merged 1 commit into
qualcomm-linux:tech/overlay/dtfrom
cjha01:nord-dt
Sep 24, 2026
Merged

Komal Bajaj (Komal-Bajaj) merged 1 commit into
qualcomm-linux:tech/overlay/dtfrom
cjha01:nord-dt

Conversation

@cjha01

Copy link
Copy Markdown

Add Makefile entries to build and install camera (camx) DTBO overlays for Nord RRD and RIDE SX board variants.

Each composite DTB bundles the respective base platform DTB with the camx overlay, and registers both the merged .dtb and standalone .dtbo.

CRs-Fixed: 4683670

@qswat-orbit-external

Copy link
Copy Markdown

Dev Completion validation failed

CR: 4683670
Change Task: kernel.qli.0.0
Error: GenAI Assisted field must be set before moving change tasks to Development Complete. Please provide GenAI information.

The change task for this CR could not be moved to Dev Complete because of the error above. Please resolve the issue in Orbit and re-run the failed Orbit check.

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1862

PR: #1862
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35572978895

# Error File:Line PR-introduced? Root Cause
1 Automerge merge conflict arch/arm64/boot/dts/qcom/Makefile Yes PR adds nord-*-camx entries that conflict with baseline qcom-next changes in the same region
2 Automerge merge conflict Multiple files (135+ conflicts) No Pre-existing conflicts between qcom-next baseline and other topic branches unrelated to this PR

Verdict

This is NOT a compilation error. The build failed during the automerge (integration) step before compilation could begin. 1 of 136 merge conflicts is directly related to this PR's changes (arch/arm64/boot/dts/qcom/Makefile). The remaining 135+ conflicts are pre-existing integration issues between the qcom-next baseline and other topic branches, unrelated to PR #1862.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1862

PR: #1862
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35572978895

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during automerge Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml No Pre-existing conflict between baseline branch qcom-next and PR base branch tech/overlay/dt. The PR does not modify this file.

Verdict

This is a pre-existing merge conflict, not introduced by PR #1862. The PR changes are limited to Nord camera device tree files and do not touch the conflicting file.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1862 — validate-patch

PR: #1862

Verdict Issues Detailed Report
✅ 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1862 - QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays
Upstream commit: N/A (vendor-only commit)
Verdict: ✅ PASS (for vendor-only commit)

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: prefix indicates vendor-only change
Body preserves rationale ✅ Clear description of Makefile entries and DTBO overlay purpose
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved ✅ Author and Signed-off-by match
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds nord-ride-sx-camx and nord-rrd-camx composite DTB entries
arch/arm64/boot/dts/qcom/nord-camera-sensor.dtsi ✅ New file: 598 lines of camera sensor definitions
arch/arm64/boot/dts/qcom/nord-camera.dtsi ✅ New file: 4535 lines of camera subsystem configuration
arch/arm64/boot/dts/qcom/nord-ride-sx-camx.dtso ✅ New overlay: 23 lines
arch/arm64/boot/dts/qcom/nord-rrd-camx.dtso ✅ New overlay: 23 lines
include/dt-bindings/camera/msm-camera.h ✅ New header: 12 lines of camera-related definitions

Issues

None. This is a well-formed vendor-only commit with the correct QCLINUX: prefix, clear commit message, proper authorship, and appropriate Signed-off-by trailer.

Verdict

Merge as-is. This is a vendor-only camera DTBO overlay addition for Nord board variants with no upstream equivalent expected.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Not checked — QCLINUX: vendor-only commit (integration_presence_report.md shows missing, but this is expected for new vendor-only additions not yet merged)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1862 — checker-log-analyzer

PR: #1862
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35572979145

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ Not run — merge failed
dt-binding-check ⏭️ Not run — merge failed
dtb-check ⏭️ Not run — merge failed
sparse-check ⏭️ Not run — merge failed
check-uapi-headers ⏭️ Not run — merge failed
check-patch-compliance ⏭️ Not run — merge failed
tag-check ✅ PASS — commit has QCLINUX: prefix
Pre-merge validation ❌ FAIL — extensive merge conflicts

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1862 - QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/35572979145
Target branch: tech/overlay/dt

Checker Result Summary
checkpatch ⏭️ Not run — merge failed
dt-binding-check ⏭️ Not run — merge failed
dtb-check ⏭️ Not run — merge failed
sparse-check ⏭️ Not run — merge failed
check-uapi-headers ⏭️ Not run — merge failed
check-patch-compliance ⏭️ Not run — merge failed
tag-check ✅ PASS — commit has QCLINUX: prefix
Pre-merge validation ❌ FAIL — extensive merge conflicts

❌ Pre-merge validation — Automerge failure

Root cause: The PR cannot be merged with the qcom-next baseline due to extensive merge conflicts across 150+ files.

Failure details:

The CI workflow attempts to merge the PR with the qcom-next baseline before running checkers. This merge failed with conflicts in:

  • DT bindings: 13 files (e.g., qcom,coresight-ctcu.yaml, qcom,glymur-evacc.yaml, qcom,kaanapali-soccp-pas.yaml)
  • DTS files: 50+ files (e.g., agatti.dtsi, eliza-*.dts, glymur-*.dts, hamoa-*.dtsi, kaanapali-*.dts, shikra-*.dts)
  • Clock drivers: 10+ files (e.g., audiocorecc-shikra.c, camcc-glymur.c, gcc-shikra.c)
  • DRM/MSM drivers: 10+ files (e.g., dp_audio.c, dp_ctrl.c, dp_display.c)
  • Other drivers: 50+ files across drivers/phy/, drivers/soc/qcom/, drivers/thermal/, sound/soc/qcom/, etc.

Sample conflicts:

CONFLICT (content): Merge conflict in arch/arm64/boot/dts/qcom/Makefile
CONFLICT (add/add): Merge conflict in arch/arm64/boot/dts/qcom/eliza-cqs-som.dtsi
CONFLICT (add/add): Merge conflict in arch/arm64/boot/dts/qcom/hamoa-camera-sensor.dtsi
CONFLICT (add/add): Merge conflict in arch/arm64/boot/dts/qcom/shikra.dtsi
CONFLICT (content): Merge conflict in drivers/clk/qcom/Kconfig
CONFLICT (content): Merge conflict in sound/soc/qcom/qdsp6/topology.c

Why this happened:

The PR targets the tech/overlay/dt branch, but the CI workflow merges it with qcom-next as the baseline for validation. The tech/overlay/dt branch has diverged significantly from qcom-next, causing widespread conflicts when the automerge tool attempts to integrate all topic branches.

Fix:

This is not a patch defect — the PR itself is clean and has the correct QCLINUX: prefix. The issue is that the target branch (tech/overlay/dt) has diverged from qcom-next and needs to be rebased or synchronized before CI can validate the PR.

Recommended actions:

  1. Rebase tech/overlay/dt onto qcom-next:

    git checkout tech/overlay/dt
    git fetch origin qcom-next
    git rebase origin/qcom-next
    # Resolve conflicts
    git push --force-with-lease
  2. Or merge qcom-next into tech/overlay/dt:

    git checkout tech/overlay/dt
    git fetch origin qcom-next
    git merge origin/qcom-next
    # Resolve conflicts
    git push
  3. Or skip automerge validation if tech/overlay/dt is intentionally divergent and this PR should be validated against tech/overlay/dt as-is (requires CI workflow adjustment).

Reproduce locally:

git clone https://github.com/qualcomm-linux/kernel.git
cd kernel
git checkout qcom-next
git fetch origin pull/1862/head:pr-1862
git merge pr-1862 --no-commit
# Observe the same conflicts

Verdict

Cannot validate — merge conflicts block CI execution.

The PR commit itself is correctly formatted with the QCLINUX: prefix (required for tech/overlay/dt branch). However, the CI cannot run any checkers because the automerge step fails with 150+ merge conflicts between tech/overlay/dt and qcom-next.

Action required: Synchronize the tech/overlay/dt branch with qcom-next before re-running CI.

@mmitkovquicinc

Copy link
Copy Markdown

I reviewed GMSL camera related changes and this looks good to me!

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1862

PR: #1862
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35588008810

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during automerge Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml No Pre-existing conflict between baseline (qcom-next) and topic branch (tech/overlay/dt) unrelated to PR changes

Verdict

The build failure is not caused by this PR. The failure occurred during the automerge step when integrating the topic branch with the baseline, encountering a pre-existing merge conflict in a file that this PR does not modify.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1862

PR: #1862
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35588008810

# Error File:Line PR-introduced? Root Cause
1 Merge conflict during automerge Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml No Pre-existing merge conflict between topic branches during CI automerge step; unrelated to PR changes

Verdict

This PR did not introduce any build errors. The failure is a pre-existing merge conflict in the integration branch that is completely unrelated to the camera DTS overlay changes in this PR.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1862 — validate-patch

PR: #1862

Verdict Issues Detailed Report
⚠️ 1 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ⚠️ — click to expand

🔍 Patch Validation

PR: #1862 - QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays
Upstream commit: N/A (vendor-only)
Verdict: ⚠️ PARTIAL

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: vendor-only commit
Body preserves rationale ✅ Clear description of Makefile entries for camx DTBO overlays
Fixes tag present/correct N/A Not a fix commit
Authorship preserved ✅ Chandan Kumar Jha cjha@qti.qualcomm.com
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds nord-ride-sx-camx and nord-rrd-camx composite DTB entries
arch/arm64/boot/dts/qcom/nord-camera-sensor.dtsi ✅ New file: 598 lines of camera sensor definitions
arch/arm64/boot/dts/qcom/nord-camera.dtsi ✅ New file: 4536 lines of camera subsystem definitions
arch/arm64/boot/dts/qcom/nord-ride-sx-camx.dtso ✅ New overlay: includes nord-camera.dtsi
arch/arm64/boot/dts/qcom/nord-rrd-camx.dtso ✅ New overlay: includes nord-camera.dtsi
include/dt-bindings/camera/msm-camera.h ✅ New header: 12 lines of camera-related defines

Issues

  • Integration presence: Commit is missing from both qcom-next and topics branches. Vendor-only commits should typically land in a topic branch before PR merge.

Verdict

Commit message and diff structure are correct for a vendor-only camera DTBO addition. However, the commit is not present in qcom-next or any topic branch, which is unusual for a PR targeting integration.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail — 1/1 commit(s) are missing from both qcom-next and topics (per integration_presence_report.md)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: d49c33864d06e9672dce57738be8851384578fcf
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1862 — checker-log-analyzer

PR: #1862
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35588008568

Checker Result Summary
Checker Result Summary
checkpatch ⏭️ Skipped - automerge conflict blocked execution
dt-binding-check ⏭️ Skipped - automerge conflict blocked execution
dtb-check ⏭️ Skipped - automerge conflict blocked execution
sparse-check ⏭️ Skipped - automerge conflict blocked execution
check-uapi-headers ⏭️ Skipped - automerge conflict blocked execution
check-patch-compliance ⏭️ Skipped - automerge conflict blocked execution
tag-check ✅ PASS - QCLINUX: prefix present
automerge ❌ FAIL - merge conflict in qcom,coresight-ctcu.yaml

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1862 - QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays
Target branch: tech/overlay/dt
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/35588008568

Checker Result Summary
checkpatch ⏭️ Skipped - automerge conflict blocked execution
dt-binding-check ⏭️ Skipped - automerge conflict blocked execution
dtb-check ⏭️ Skipped - automerge conflict blocked execution
sparse-check ⏭️ Skipped - automerge conflict blocked execution
check-uapi-headers ⏭️ Skipped - automerge conflict blocked execution
check-patch-compliance ⏭️ Skipped - automerge conflict blocked execution
tag-check ✅ PASS - QCLINUX: prefix present
automerge ❌ FAIL - merge conflict in qcom,coresight-ctcu.yaml

❌ automerge — Merge Conflict

Root cause: The PR cannot be merged into the tech/overlay/dt branch due to a merge conflict in Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml during the automerge phase (which merges qcom-next baseline + topic branch + PR).

Failure details:

Normal merge conflict for 'Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml':
  {local}: modified file
  {remote}: modified file
automerge returned non-zero; check logs for conflicts

Analysis:

This PR adds camera DTBO overlays for Nord (nord-camera.dtsi, nord-camera-sensor.dtsi, nord-rrd-camx.dtso, nord-ride-sx-camx.dtso) and does not touch Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml.

The conflict arises during the CI automerge workflow, which:

  1. Checks out the tech/overlay/dt base branch
  2. Runs automerge to integrate qcom-next baseline + topic branches
  3. Merges the PR on top

The conflict is in a DT binding file (qcom,coresight-ctcu.yaml) that is unrelated to this PR's camera changes. This indicates:

  • Either the tech/overlay/dt branch has diverged from qcom-next and has conflicting changes to this binding file
  • Or another topic branch being merged by automerge has conflicting changes

Fix:

This is not a defect in the PR itself — the PR content is clean. The conflict must be resolved in one of two ways:

Option 1: Rebase the target branch (recommended if you maintain tech/overlay/dt)

# Update tech/overlay/dt to resolve conflicts with qcom-next
git checkout tech/overlay/dt
git fetch origin qcom-next
git rebase origin/qcom-next
# Resolve the conflict in qcom,coresight-ctcu.yaml
git add Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml
git rebase --continue
git push --force-with-lease origin tech/overlay/dt

Option 2: Merge qcom-next into the target branch

git checkout tech/overlay/dt
git fetch origin qcom-next
git merge origin/qcom-next
# Resolve the conflict in qcom,coresight-ctcu.yaml
git add Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml
git commit
git push origin tech/overlay/dt

After fixing the base branch conflict, re-trigger the CI run — all checkers should execute successfully.

Reproduce locally:

git clone https://github.com/qualcomm-linux/kernel.git
cd kernel
git checkout tech/overlay/dt
git fetch origin qcom-next
git merge origin/qcom-next
# Conflict will appear in qcom,coresight-ctcu.yaml

✅ tag-check — Subject Prefix

Status: PASS

The commit subject starts with QCLINUX:, which is a valid prefix for vendor-only changes. Since the target branch is tech/overlay/dt (not qcom-next or qcom-next-staging), the subject prefix requirement applies and is satisfied.

Note: QCLINUX: commits will always fail check-patch-compliance (which requires FROMLIST:/FROMGIT:/UPSTREAM:/BACKPORT: and a Link: tag) because they are vendor-only changes with no upstream equivalent. This is a known limitation of the checker for vendor-internal commits.


Verdict

Blocker: Automerge conflict in Documentation/devicetree/bindings/arm/qcom,coresight-ctcu.yaml must be resolved in the tech/overlay/dt base branch before this PR can be merged.

PR content: Clean — no issues detected in the patch itself. The conflict is in the base branch, not introduced by this PR.

Action required: Maintainer of tech/overlay/dt must resolve the qcom-next merge conflict, then re-trigger CI.

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1862

PR: #1862
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35632645432

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'nord-ride-sx.dtb' arch/arm64/boot/dts/qcom/Makefile:563 Yes Makefile references non-existent base DTB file nord-ride-sx.dtb

Verdict

1 of 1 errors is introduced by this PR. The build failure is entirely caused by the PR changes.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1862

PR: #1862
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35632645432

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'nord-ride-sx.dtb' arch/arm64/boot/dts/qcom/Makefile:563 Yes PR references non-existent base DTB nord-ride-sx.dtb in composite DTB rule; only nord-ride.dtb and nord-ride-embedded.dtb exist in tree

Verdict

The single build error is introduced by this PR. The PR attempts to create a composite DTB (nord-ride-sx-camx.dtb) that depends on a base DTB (nord-ride-sx.dtb) which does not exist in the kernel tree.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1862

PR: #1862
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35638640184

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'arch/arm64/boot/dts/qcom/nord-ride-sx.dtb' arch/arm64/boot/dts/qcom/Makefile:563 Yes PR adds Makefile rule referencing non-existent base DTB nord-ride-sx.dtb

Verdict

The single build error is introduced by this PR. The PR adds a composite DTB rule that depends on nord-ride-sx.dtb, but this base device tree file does not exist in the kernel tree.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1862

PR: #1862
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35638640184

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'arch/arm64/boot/dts/qcom/nord-ride-sx.dtb' arch/arm64/boot/dts/qcom/Makefile:563 Yes PR references non-existent base DTB nord-ride-sx.dtb in composite DTB definition

Verdict

The single build error is introduced by this PR. The PR adds a composite DTB entry that references a base DTB file (nord-ride-sx.dtb) that does not exist in the kernel tree.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1862 — validate-patch

PR: #1862

Verdict Issues Detailed Report
✅ 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1862 - QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays
Upstream commit: N/A (vendor-only commit)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: prefix indicates vendor-only commit
Body preserves rationale ✅ Clear description of Makefile changes for DTBO overlays
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved ✅ Author and Signed-off-by match
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds nord-ride-sx-camx and nord-rrd-camx DTBO build entries
arch/arm64/boot/dts/qcom/nord-camera-sensor.dtsi ✅ New file: camera sensor definitions (598 lines)
arch/arm64/boot/dts/qcom/nord-camera.dtsi ✅ New file: camera subsystem definitions (4541 lines)
arch/arm64/boot/dts/qcom/nord-ride-sx-camx.dtso ✅ New overlay: RIDE SX camera overlay (23 lines)
arch/arm64/boot/dts/qcom/nord-rrd-camx.dtso ✅ New overlay: RRD camera overlay (23 lines)
include/dt-bindings/camera/msm-camera.h ✅ Adds camera-related dt-bindings (12 lines)

Verdict

Merge as-is. This is a vendor-only commit (QCLINUX: prefix) adding camera DTBO overlays for Nord board variants. The commit message is clear, authorship is correct, and the changes are self-contained. No upstream validation is required or expected for QCLINUX: commits.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Not checked — QCLINUX: vendor-only commit (integration_presence_report.md shows missing, which is expected for new vendor-only features not yet integrated)

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: 56321f1b03c171fa3665a6f16a89f47a71a56dad
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays missing - no subject, patch-id, or full tree-content match found missing - no subject, patch-id, or full tree-content match found missing

Final Status

overall_status: FAIL
present_commits: 0/1
partial_commits: 0/1
missing_commits: 1/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Fail - 1/1 commit(s) are missing from both qcom-next and topics

@qlijarvis

Copy link
Copy Markdown

PR #1862 — checker-log-analyzer

PR: #1862
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35638640978

Checker Result Summary
Checker Result Summary
checkpatch ❌ 91 warnings - undocumented DT compatible strings
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ QCLINUX: prefix not in allowed list
tag-check ⚠️ Cannot determine - target branch unknown

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1862 - QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/35638640978

Checker Result Summary
checkpatch ❌ 91 warnings - undocumented DT compatible strings
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Passed
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ QCLINUX: prefix not in allowed list
tag-check ⚠️ Cannot determine - target branch unknown

❌ checkpatch

Root cause: 91 undocumented DT compatible strings for camera subsystem components.

Failure details:

The commit introduces numerous camera-related DT nodes with compatible strings that lack corresponding binding documentation:

WARNING: DT compatible string "qcom,cam-gmsl-sensor" appears un-documented (21 instances)
WARNING: DT compatible string "qcom,cam-res-mgr" appears un-documented
WARNING: DT compatible string "qcom,cam-cpas" appears un-documented
WARNING: DT compatible string "qcom,cam-icp_v3_0" appears un-documented (2 instances)
WARNING: DT compatible string "qcom,cam-ipe" appears un-documented (2 instances)
WARNING: DT compatible string "qcom,cam-tpg104" appears un-documented (3 instances)
WARNING: DT compatible string "qcom,vfe900" appears un-documented (3 instances)
WARNING: DT compatible string "qcom,csid900" appears un-documented (3 instances)
WARNING: DT compatible string "qcom,sfe-lite690" appears un-documented (3 instances)
WARNING: DT compatible string "qcom,ccu-cci" appears un-documented (5 instances)
WARNING: DT compatible string "qcom,csid-lite900" appears un-documented (3 instances)
WARNING: DT compatible string "qcom,vfe-lite900" appears un-documented (3 instances)

Total: 0 errors, 91 warnings, 0 checks, 5219 lines checked

Fix:

These are vendor-specific camera subsystem compatible strings. You have two options:

  1. Add DT binding documentation (upstream-friendly approach):

    • Create Documentation/devicetree/bindings/media/qcom,cam-*.yaml files for each compatible string
    • Follow the DT schema format with proper properties:, required:, and examples: sections
    • This is required if these bindings will eventually go upstream
  2. Accept the warnings (vendor-only approach):

    • If these are purely vendor-internal camera components with no upstream plans, the warnings can be accepted
    • Document the decision in the PR description
    • Note that checkpatch warnings don't block merge for vendor-only changes

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git a9ddf5e5ad28be8a9a43e5af6e2c75188343f538..2f2570f913c72bbe9cac96cd1217d9f8398dfa20

❌ check-patch-compliance

Root cause: QCLINUX: prefix is not in the checker's allowed list of prefixes.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays
Commit summary does not start with a required prefix

Analysis:

This is a known limitation of the check-patch-compliance checker. The checker only accepts upstream-linkable prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (in maintainer tree)
  • UPSTREAM: (merged to mainline)
  • BACKPORT: (backported with modifications)

The QCLINUX: prefix is used for vendor-only changes with no upstream equivalent, which is appropriate for this camera DTBO overlay commit. However, the checker will always fail for such commits.

Fix:

No action required. This is expected behavior for vendor-only commits. The QCLINUX: prefix is correct for this use case. The checker limitation is documented and understood by maintainers.

If this commit were to be posted upstream in the future, you would:

  1. Change the prefix to FROMLIST:
  2. Add a Link: trailer pointing to the lore.kernel.org URL
  3. Ensure the commit has an upstream-acceptable commit message

Reproduce locally:

# This checker requires the kernel-checkers repository
cd kernel-checkers
./check-patch-compliance.sh --kernel-src <path> --base <base_sha> --head <head_sha>

⚠️ tag-check (branch-dependent)

Status: Cannot determine without target branch information.

Analysis:

The tag-check validation depends on the PR's target branch:

  • If targeting qcom-next or qcom-next-staging: ✅ PASS (prefix not required)
  • If targeting any other branch: ✅ PASS (QCLINUX: is a valid prefix)

The commit subject QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays uses the QCLINUX: prefix, which is one of the accepted prefixes for branches other than qcom-next/qcom-next-staging.

Valid prefixes: FROMLIST:, FROMGIT:, UPSTREAM:, BACKPORT:, QCLINUX:, PENDING:, WORKAROUND:

Since the commit has a valid prefix, this check would pass regardless of the target branch.


Verdict

2 checker failures, but both are expected for vendor-only camera DTBO changes:

  1. checkpatch warnings (91): Undocumented camera compatible strings - acceptable for vendor-only code, or add binding documentation if upstream plans exist
  2. check-patch-compliance: Known limitation with QCLINUX: prefix - no action needed

Recommendation:

  • If vendor-only with no upstream plans: Merge as-is. Document in PR that checkpatch warnings are accepted for vendor camera subsystem.
  • If upstream plans exist: Add DT binding YAML files for the camera compatible strings before merge.

All other checkers (dtb-check, sparse-check, check-uapi-headers) passed successfully.

Comment thread arch/arm64/boot/dts/qcom/Makefile Outdated

nord-ride-sx-camx-dtbs := nord-ride-sx.dtb nord-ride-sx-camx.dtbo

dtb-$(CONFIG_ARCH_QCOM) += nord-ride-sx-camx.dtb

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make nord-ride-sx to nord-ride-embedded. (aligned to upstream)

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@apateriy-qcom

Copy link
Copy Markdown

Please fix checkpatch issues.

@cjha01
Chandan Jha (cjha01) force-pushed the nord-dt branch 2 times, most recently from abf47f5 to 733eddf Compare September 23, 2026 14:49
@cjha01

Copy link
Copy Markdown
Author

Please fix checkpatch issues.

Done.

Comment thread arch/arm64/boot/dts/qcom/nord-camera.dtsi Outdated
Add Makefile entries to build and install camera (camx) DTBO overlays
for Nord RRD and RIDE SX board variants.

Each composite DTB bundles the respective base platform DTB with the
camx overlay, and registers both the merged .dtb and standalone .dtbo.

Signed-off-by: Chandan Kumar Jha <cjha@qti.qualcomm.com>
@Komal-Bajaj
Komal Bajaj (Komal-Bajaj) merged commit ae50c51 into qualcomm-linux:tech/overlay/dt Sep 24, 2026
5 of 7 checks passed
@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1862

PR: #1862
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35696239783

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'nord-ride-sx.dtb' arch/arm64/boot/dts/qcom/Makefile No Pre-existing Makefile entry for nord-ride-sx-camx.dtb depends on missing nord-ride-sx.dtb base file

Verdict

The build failure is NOT introduced by this PR. The error is a pre-existing issue in the kernel tree where nord-ride-sx-camx.dtb composite target depends on nord-ride-sx.dtb, but that base DTB file is not defined in the Makefile or doesn't exist.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1862

PR: #1862
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35696239783

# Error File:Line PR-introduced? Root Cause
1 No rule to make target 'arch/arm64/boot/dts/qcom/nord-ride-sx.dtb' arch/arm64/boot/dts/qcom/Makefile No Pre-existing Makefile entry for nord-ride-sx-camx.dtb references missing base DTB nord-ride-sx.dtb

Verdict

0 of 1 errors are introduced by this PR; 1 is pre-existing.

The build failure is caused by a pre-existing issue in the kernel tree where nord-ride-sx-camx.dtb is defined in the Makefile but its required base file nord-ride-sx.dtb does not exist. This PR only adds entries for nord-ride-embedded-camx and nord-rrd-camx, which are unrelated to the failing nord-ride-sx-camx target.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

PR #1862 — validate-patch

PR: #1862

Verdict Issues Detailed Report
✅ 0 Full report

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics
Verdict: ✅ — click to expand

🔍 Patch Validation

PR: #1862 - QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays
Upstream commit: N/A (vendor-only commit)
Verdict: ✅ PASS

Commit Message

Check Status Note
Subject matches upstream N/A QCLINUX: prefix indicates vendor-only commit
Body preserves rationale ✅ Clear description of Makefile entries and composite DTB structure
Fixes tag present/correct N/A Not a fix; new feature addition
Authorship preserved ✅ Author: Chandan Kumar Jha; Signed-off-by present
Backport note (if applicable) N/A Not a backport

Diff

File Status Notes
arch/arm64/boot/dts/qcom/Makefile ✅ Adds nord-ride-embedded-camx and nord-rrd-camx composite DTB entries
arch/arm64/boot/dts/qcom/nord-camera-sensor.dtsi ✅ New file: 598 lines of camera sensor definitions
arch/arm64/boot/dts/qcom/nord-camera.dtsi ✅ New file: 4550 lines of camera subsystem definitions
arch/arm64/boot/dts/qcom/nord-ride-embedded-camx.dtso ✅ New overlay: 23 lines
arch/arm64/boot/dts/qcom/nord-rrd-camx.dtso ✅ New overlay: 23 lines
include/dt-bindings/camera/msm-camera.h ✅ New header: 12 lines of camera-related definitions

Issues

None. The commit message is well-structured with a clear subject line, descriptive body explaining the purpose of the changes, and proper sign-off. All files are new additions (no modifications to existing code), and the Makefile changes follow the existing pattern for composite DTB entries in the same file.

Verdict

Merge as-is. This is a vendor-only commit adding camera DTBO overlay support for Nord board variants. The commit message clearly describes the changes, authorship is correct, and the diff is internally consistent.

Final Summary

  1. Lore link present: No — QCLINUX: prefix; no lore link expected or required
  2. Lore link matches PR commits: N/A — no lore link to compare against
  3. Upstream patch status: N/A — vendor-only change, not posted upstream
  4. PR present in qcom-next/topics: Yes — commit found in topics at ae50c51

Deterministic Integration Presence

Integration Presence Report

This report is generated by Jarvis before validate-patch runs.
It is the authoritative source for whether PR changes are already present
in qcom-next or in the kernel topic branches.

Kernel repo: /local/mnt/workspace/sgaud/Qgenie/image_pipeline/kernel
qcom-next ref: a47c4c5aa34b866136077d023d7c9e78d5a2225b
topics remote: topics -> https://github.com/qualcomm-linux/kernel-topics
topics fetch: fetched

Commit Subject qcom-next topics Final
1/1 [PATCH] QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays missing - no subject, patch-id, or full tree-content match found present - exact patch-id match at ae50c51 present

Final Status

overall_status: PASS
present_commits: 1/1
partial_commits: 0/1
missing_commits: 0/1
topics_checked_for_commits: 1/1
final_summary: PR present in qcom-next/topics: Yes - all 1 commit(s) are present in qcom-next or topics

@qlijarvis

Copy link
Copy Markdown

PR #1862 — checker-log-analyzer

PR: #1862
Checker run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35696239883

Checker Result Summary
Checker Result Summary
checkpatch ❌ 91 warnings - undocumented DT compatible strings
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Test passed
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ QCLINUX: prefix not accepted
tag-check ✅ N/A (target branch is tech/overlay/dt, not qcom-next/qcom-next-staging)

Detailed report: Full report

Checker analysis — click to expand

🤖 CI Checker Analysis (checker-log-analyzer)

PR: #1862 - QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays
Source: https://github.com/qualcomm-linux/kernel-config/actions/runs/35696239883

Checker Result Summary
checkpatch ❌ 91 warnings - undocumented DT compatible strings
dt-binding-check ⏭️ No binding changes
dtb-check ✅ Test passed
sparse-check ✅ Passed
check-uapi-headers ✅ Passed
check-patch-compliance ❌ QCLINUX: prefix not accepted
tag-check ✅ N/A (target branch is tech/overlay/dt, not qcom-next/qcom-next-staging)

❌ checkpatch

Root cause: 91 undocumented DT compatible strings across camera sensor and subsystem nodes.

Failure details:

WARNING: DT compatible string "qcom,cam-gmsl-sensor" appears un-documented (20 instances)
WARNING: DT compatible string "qcom,vfe-lite900" appears un-documented (10 instances)
WARNING: DT compatible string "qcom,csid-lite900" appears un-documented (10 instances)
WARNING: DT compatible string "qcom,csiphy-v2.5.0" appears un-documented (5 instances)
WARNING: DT compatible string "qcom,csiphy" appears un-documented (5 instances)
WARNING: DT compatible string "qcom,ccu-cci" appears un-documented (5 instances)
WARNING: DT compatible string "qcom,cam-rt-cdm3_1" appears un-documented (5 instances)
... and 24 more unique compatible strings

All warnings are UNDOCUMENTED_DT_STRING type for camera subsystem compatible strings in:

  • arch/arm64/boot/dts/qcom/nord-camera-sensor.dtsi
  • arch/arm64/boot/dts/qcom/nord-camera.dtsi

Fix: Add DT binding documentation for all camera subsystem compatible strings. Create Documentation/devicetree/bindings/media/qcom,camss-*.yaml files covering:

  • qcom,cam-gmsl-sensor (GMSL camera sensor)
  • qcom,vfe-lite900, qcom,vfe900 (Video Front End)
  • qcom,csid-lite900, qcom,csid900 (CSID)
  • qcom,csiphy-v2.5.0, qcom,csiphy (CSI PHY)
  • qcom,cam-cpas, qcom,cam-isp, qcom,cam-icp*, etc. (camera subsystem nodes)

Alternatively, if these are vendor-specific camera nodes not intended for upstream, the warnings can be noted as expected for internal-only DTS additions.

Reproduce locally:

./scripts/checkpatch.pl --strict --ignore FILE_PATH_CHANGES --git <base>..HEAD

❌ check-patch-compliance

Root cause: Commit uses QCLINUX: prefix, which is not in the checker's allowed list.

Failure details:

Checking commit: QCLINUX: arm64: dts: qcom: nord: Add camx DTBO overlays
Commit summary does not start with a required prefix

Fix: This is a known limitation of the check-patch-compliance checker. The checker only accepts upstream-linkable prefixes:

  • FROMLIST: (posted to mailing list)
  • FROMGIT: (in a maintainer tree)
  • UPSTREAM: (merged into mainline)
  • BACKPORT: (backported with modifications)

The QCLINUX: prefix is used for vendor-only changes with no upstream equivalent. Since this PR adds vendor-specific camera DTBO overlays for internal boards, the QCLINUX: prefix is correct and this checker failure is expected.

No action required — this is a vendor-only commit and the prefix is appropriate.

Reproduce locally:

# The checker will always fail for QCLINUX: prefixed commits
# This is expected behavior for vendor-only changes

Verdict

2 blockers to address before merge:

  1. checkpatch (91 warnings) — All undocumented DT compatible strings. If these camera nodes are vendor-specific and not intended for upstream, document this decision and consider whether bindings should be added to the internal tree for consistency.

  2. check-patch-compliance (expected failure) — The QCLINUX: prefix is correct for vendor-only changes. This failure is a known limitation of the checker and does not block merge. However, confirm that these camera nodes are indeed vendor-only and not candidates for upstream submission.

Recommendation: If the camera subsystem nodes are vendor-specific, merge as-is with the understanding that the checkpatch warnings are expected for undocumented vendor compatibles. If any of these nodes are intended for upstream, add proper DT bindings first.

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1862

PR: #1862
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35715450760

# Error File:Line PR-introduced? Root Cause
1 Failed to apply 'nord-rrd-camx.dtbo': FDT_ERR_NOTFOUND arch/arm64/boot/dts/qcom/Makefile:569 Yes Makefile references non-existent base DTB nord-rrd.dtb
2 Failed to apply 'nord-ride-embedded-camx.dtbo': FDT_ERR_NOTFOUND arch/arm64/boot/dts/qcom/Makefile:563 Yes Makefile references non-existent base DTB nord-ride-embedded.dtb

Verdict

Both errors are introduced by this PR. The PR adds composite DTB targets that depend on base DTB files that do not exist in the kernel tree.

📎 Detailed analysis: Full report

@qlijarvis

Copy link
Copy Markdown

🔨 Build Failure Analysis — PR #1862

PR: #1862
Build run: https://github.com/qualcomm-linux/kernel-config/actions/runs/35715450760

# Error File:Line PR-introduced? Root Cause
1 Failed to apply 'nord-rrd-camx.dtbo': FDT_ERR_NOTFOUND arch/arm64/boot/dts/qcom/Makefile:39 Yes Composite DTB rule references non-existent base DTB nord-rrd.dtb
2 Failed to apply 'nord-ride-embedded-camx.dtbo': FDT_ERR_NOTFOUND arch/arm64/boot/dts/qcom/Makefile:34 Yes Composite DTB rule references non-existent base DTB nord-ride-embedded.dtb

Verdict

Both errors are introduced by this PR. The PR adds composite DTB overlay rules that depend on base DTB files (nord-rrd.dtb and nord-ride-embedded.dtb) which do not exist in the kernel tree.

📎 Detailed analysis: Full report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants