FROMLIST: drm/bridge: anx7625: Fix register access in low-power mode - #1903
Merged
riteshk-quic merged 1 commit intoSep 24, 2026
Merged
Conversation
The INTERFACE_CHANGE_INT_MASK register was accessed outside the Type-C initialization path added for minimal Type-C support. On platforms without Type-C support, this causes the driver to access the RX-P0 I2C client while the ANX7625 is in its low-power configuration. The access fails during probe and results in errors such as: [drm:i2c_access_workaround.isra.0 [anx7625]] *ERROR* fail to access i2c id=3f :39 [drm:anx7625_i2c_probe [anx7625]] *ERROR* fail to write i2c id=3f :43 Keep the interrupt-mask update within the low-power-mode check block. Link: https://lore.kernel.org/all/20260924-latest_tag-v1-1-7150d373f042@oss.qualcomm.com/ Fixes: f81455b ("drm: bridge: anx7625: implement minimal Type-C support") Reported-by: Salendarsingh Gaud <sgaud@qti.qualcomm.com> Signed-off-by: Arpit Saini <arpit.saini@oss.qualcomm.com>
|
Dev Completion validation failed CR: 4689083 The change task for this CR could not be moved to Dev Complete because of the error above. Please resolve the issue in Orbit and re-run the failed Orbit check. |
qcomlnxci
requested review from
a team,
Rajesh Kemisetti (quic-rajeshk) and
riteshk-quic
and removed request for
a team
September 24, 2026 11:27
riteshk-quic
approved these changes
Sep 24, 2026
riteshk-quic
merged commit Sep 24, 2026
d42e9c7
into
qualcomm-linux:tech/mm/drm
4 of 7 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The INTERFACE_CHANGE_INT_MASK register was accessed outside the Type-C initialization path added for minimal Type-C support.
On platforms without Type-C support, this causes the driver to access the RX-P0 I2C client while the ANX7625 is in its low-power configuration. The access fails during probe and results in errors such as:
[drm:i2c_access_workaround.isra.0 [anx7625]]
ERROR fail to access i2c id=3f :39
[drm:anx7625_i2c_probe [anx7625]] ERROR fail to write i2c id=3f :43
Keep the interrupt-mask update within the low-power-mode check block.
Link: https://lore.kernel.org/all/20260924-latest_tag-v1-1-7150d373f042@oss.qualcomm.com/
Fixes: f81455b ("drm: bridge: anx7625: implement minimal Type-C support")
Reported-by: Salendarsingh Gaud sgaud@qti.qualcomm.com
CRs-Fixed: 4689083