Conversation
kshiruri
force-pushed
the
bootbins-immutable-support
branch
from
September 25, 2026 05:31
5a4fe2d to
928d2fa
Compare
…r targets
For spinor-equipped targets, gen-flash-dirs.sh now searches for programmer
binaries using the *.melf file pattern instead of searching using file name.
The BOOT_BIN_SRC location is determined by checking in order:
1. ${BOARD_BOOT_DIR}/partition_${storage}/ — if it exists
2. ${BOARD_BOOT_DIR}/${storage}/ — if partition_${storage}/ doesn't exist
3. ${BOARD_BOOT_DIR}/ — fallback to root if neither above exists
Once BOOT_BIN_SRC is determined, for non-spinor storages on spinor targets,
the search uses find to locate *.melf files within BOOT_BIN_SRC and copies
only those programmer binaries, aligning with the search logic used in
Yocto builds (recipes-bsp/firmware-boot/firmware-qcom-boot-common.inc).
Spinor storage continues to receive the full boot-bin archive contents.
Non-spinor targets remain unaffected — the full archive is still copied
to all supported storage directories.
Signed-off-by: Karthik Shiruri <kshiruri@qti.qualcomm.com>
kshiruri
force-pushed
the
bootbins-immutable-support
branch
from
September 25, 2026 06:29
928d2fa to
24963e3
Compare
kshiruri
marked this pull request as ready for review
September 29, 2026 11:26
Author
|
Hi Keerthi Gowda (@keerthi-go) Bjordis Collaku (@bjordiscollaku) please help in testing this on hamoa/purva. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update search logic to find programmer binaries in order to mirror the logic used in yocto recipe
Changes
flash/gen-flash-dirs.sh
For Spinor targets:
When the target has no spinor storage: behavior is unchanged — the full boot-bin archive is copied into every supported storage dir, as before.