Repository navigation
[reproduce] Preserve linker inputs when reproduce link fails - #2068
Steven Ramirez Rosa (Steven6798) wants to merge 1 commit into
Conversation
| // namespecs that have an explicit mapping entry, preserving normal mapped | ||
| // link behavior. | ||
| if (PConfig.options().hasMappingFile() && !isInternal() && | ||
| (Type != Input::Namespec || PConfig.hasMappingForFile(FileName))) |
There was a problem hiding this comment.
Can this condition be simplified or made into a seperate function ?
Input::resolveReproducePath() ?
This will allow the critical code without reproduce unaffected.
There was a problem hiding this comment.
Sounds good.
There was a problem hiding this comment.
Let me know if my latest change is what you were looking for.
| @@ -1763,6 +1770,8 @@ bool GnuLdDriver::processReproduceOption( | |||
| break; | |||
| } | |||
There was a problem hiding this comment.
I could not follow this.
There was a problem hiding this comment.
We cannot just return because we failed to resolve the action. That's how we end up without the input file in the reproduce.
d73074a to
2f5b3d9
Compare
2f5b3d9 to
20b4b5e
Compare
Capture linker scripts and unresolved namespecs when input activation fails so the reproduce response preserves the original failure. Avoid applying mapping-file resolution to unmapped replay namespecs while retaining normal mapped namespec behavior. Fix: qualcomm#1014 Signed-off-by: Steven Ramirez Rosa <ramirezr@qti.qualcomm.com>
20b4b5e to
d184caa
Compare
|
Tests have to be updated after rebasing latest reproduce changes. |
|
check-llvm-test-suite |
|
LLVM test suite request accepted for |
|
✅ LLVM test suite passed for |
This branch has not been deployed
4 participants
Capture linker scripts and unresolved namespecs when input activation fails so the reproduce response preserves the original failure. Avoid applying mapping-file resolution to unmapped replay namespecs while retaining normal mapped namespec behavior.
Fix: #1014