Repository navigation
chore: bump go directive to 1.26.10 (clears reachable stdlib vulns) - #54
Merged
Merged
Conversation
govulncheck flagged 10 reachable stdlib vulnerabilities on the 1.26.8 toolchain (net/http and crypto/x509, reached via cronoapi.Client and cmd.Execute). Bumping the go directive to 1.26.10 lets setup-go pull a patched toolchain in CI; no source changes needed. Same fix pattern as quantcli/liftoff-export-cli#67. Co-Authored-By: Paperclip <noreply@paperclip.ing>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Checked crono-export-cli for the same govulncheck failure flagged in QUA-65 for liftoff-export-cli. On the 1.26.8 toolchain,
govulncheck ./...reports 10 reachable stdlib vulnerabilities (net/http and crypto/x509) viacronoapi.Client.submitLogin/cmd.Execute.What changed
Bumped the
godirective ingo.modfrom1.26.8to1.26.10. CI usesgo-version-file: go.mod, so no workflow file changes are needed.Verification
go build ./...— passesgo vet ./...— cleango test ./...— passesgovulncheck ./...on 1.26.8: 10 reachable stdlib vulns. On 1.26.10 (this PR): No vulnerabilities foundSame fix pattern as quantcli/liftoff-export-cli#67.