Repository navigation
Format and lint - #17
Merged
Merged
Conversation
Line length stays at the default of 88. The data tables are excluded, as they will move out of the package. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
\theta was read as a tab and \phi as an invalid escape. Since warnings fail the tests, editing these files made the suite fail on import. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Formatting only, produced by ruff 0.17.2. Syntax trees are unchanged up to whitespace in docstrings. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The 113 findings present after formatting are listed by rule per file, not fixed. New files get the full rule set. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Comments, docstrings and documentation only. Reson, as in J. Magn. Reson., is added to the codespell ignore list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Ruff check and format, codespell, and validation of the workflow and of pyproject.toml, at pinned versions. The new Lint job runs the same checks, and Pass now also waits for it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
E.
format-and-lint[tool.ruff]: default line length (88), the agreed rules,src/openquad/data/excludedfrom formatting since those tables move in step 3. Also
*.mdexcluded, at themaintainer's choice: ruff 0.17 formats code blocks in Markdown, and the README
examples keep their hand-written layout
.pre-commit-config.yamlwith pinned versions: ruff v0.17.2, codespell v2.4.3,check-jsonschema 0.39.0, validate-pyproject v0.27, the newest at least two weeks old.
Standard isolated hook environments, approved by the maintainer; the one-off
download took 25 s
ci.yml: ubuntu, Python 3.13,prek run --all-files, same config aslocal.
Passwaits for itruff format(f3fde52), listed in.git-blame-ignore-revs.Tests unchanged (57 passed, 5 xfailed); syntax trees equal up to docstring
whitespace. The entry needs the hash to survive the merge: merge commit, no rebase
per-file-ignores, by rule per file: 113 findings in 19files. Not fixed
codespell: 21 typos fixed in comments, docstrings and docs;reson(J. Magn.Reson.) on the ignore list
grid.pyandfibonacci.py, at the maintainer's choice,before the format commit. See "Hidden syntax warnings" under findings