Agrandar diagonal cream del login en mobile - #77
Merged
Merged
Conversation
El fix anterior (achicar la diagonal para no tapar "Iniciar sesion") la dejo tan chica que "GESTION ACTIVA EN USD" quedaba pisando la zona negra. Se agranda el ancho del triangulo (62% -> 78%, igual que en desktop) sin tocar la altura, asi el tagline entra completo en la zona cream y el titulo sigue sin superponerse. Verificado en 320px, 375px, tablet y desktop.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contexto
El fix anterior para que la diagonal cream del login no tapara el título "Iniciar sesión" en mobile la dejó muy chica: el tagline "GESTIÓN ACTIVA EN USD" quedaba pisando la zona negra.
Fix
Se agranda el ancho del triángulo cream en mobile (<640px) de 62% a 78% (igual que en el breakpoint de desktop), sin tocar la altura de 32% que evita que tape el título.
Test plan
npm run lint,npm run format:check,npm run test:ci(481 tests) en verde