You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Fix qlog.Config.Tracer example to create and run a connection trace
Updates the example callback in qlog.md to pass the client flag, connection ID, and event schema list to qlogwriter.NewConnectionFileSeq. The returned trace is started with Run in a goroutine and then returned.
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Source mode: Auto
Repository: Unavailable
Branch: Unavailable
File: No configuration file from this repository applied
Commit: Unavailable
Layers: Organization UI
Review profile: CHILL
Plan: Advanced
Run ID: 0b309c0e-7f54-4074-8418-9e6c614d9bd5
📥 Commits
Reviewing files that changed from the base of the PR and between 40bb892 and b23c8fc.
📒 Files selected for processing: 1
content/docs/quic/qlog.md
Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.
📝 Walkthrough
The connection qlog example now creates a trace with the file, client flag, connection ID, and qlog.EventSchema. It starts trace.Run() in a goroutine and returns the trace.
Changes: Connection qlog example
Layer / File(s)
Summary
Configure and run the connection trace content/docs/quic/qlog.md
The example replaces NewConnectionFileSeq(f) with a configured trace, starts trace.Run() in a goroutine, and returns the trace.
No merge-blocking risk is identified in this example update.
Pre-merge checks: 5
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly and concisely describes the main change: fixing the qlog connection tracer example.
Docstring Coverage
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
🧪 Generate unit tests (beta)
Commit to this branch
Create a new PR
✨ Simplify code
Commit to this branch
Create a new PR
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
qlog.Config.Tracerexample to create and run a connection traceUpdates the example callback in qlog.md to pass the client flag, connection ID, and event schema list to
qlogwriter.NewConnectionFileSeq. The returned trace is started withRunin a goroutine and then returned.Macroscope summarized b23c8fc.
Summary by CodeRabbit