Skip to content

quic: fix qlog connection tracer example - #140

Merged
marten-seemann merged 1 commit into
masterfrom
fix-qlog-conn-tracer
Oct 22, 2026
Merged

marten-seemann merged 1 commit into
masterfrom
fix-qlog-conn-tracer

Conversation

@marten-seemann

@marten-seemann marten-seemann commented Oct 22, 2026 •

Copy link
Copy Markdown
Member

Fix qlog.Config.Tracer example to create and run a connection trace

Updates the example callback in qlog.md to pass the client flag, connection ID, and event schema list to qlogwriter.NewConnectionFileSeq. The returned trace is started with Run in a goroutine and then returned.

Macroscope summarized b23c8fc.

Summary by CodeRabbit

  • Documentation
    • Updated the QUIC qlog connection example to create and return a connection trace configured with the client flag, connection ID, and event schema.
    • The example now starts the trace’s run method in a background goroutine instead of directly using the previous connection-file sequence approach.

@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0b309c0e-7f54-4074-8418-9e6c614d9bd5
📥 Commits

Reviewing files that changed from the base of the PR and between 40bb892 and b23c8fc.

📒 Files selected for processing: 1
  • content/docs/quic/qlog.md

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

The connection qlog example now creates a trace with the file, client flag, connection ID, and qlog.EventSchema. It starts trace.Run() in a goroutine and returns the trace.

Changes: Connection qlog example

Layer / File(s) Summary
Configure and run the connection trace
content/docs/quic/qlog.md
The example replaces NewConnectionFileSeq(f) with a configured trace, starts trace.Run() in a goroutine, and returns the trace.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Merge Risk: ⚪ Minimal · up to b23c8

No merge-blocking risk is identified in this example update.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely describes the main change: fixing the qlog connection tracer example.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
✨ Simplify code
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@marten-seemann
marten-seemann merged commit 8ae19d7 into master Oct 22, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant