Skip to content

Ensure function prototype is propagated when bound - #1733

Merged
saghul merged 1 commit into
quickjs-ng:masterfrom
sr5434:Function-prototype-bind-retain-proto
Oct 1, 2026
Merged

saghul merged 1 commit into
quickjs-ng:masterfrom
sr5434:Function-prototype-bind-retain-proto

Conversation

@sr5434

@sr5434 sr5434 commented Sep 20, 2026

Copy link
Copy Markdown
Contributor

Fixes #1732 and adds a regression test. Basically, when a generator function is bound, the previous (incorrect) behavior would be to return a standard function.

@sr5434

sr5434 commented Sep 30, 2026

Copy link
Copy Markdown
Contributor Author

Hey @saghul @bnoordhuis, when you guys get a chance, would you mind reviewing this PR and #1734? I saw that a bunch of new PRs came in, so I just wanted to make sure that these don't get buried. Thanks!

@saghul
saghul merged commit 6a9b531 into quickjs-ng:master Oct 1, 2026
128 checks passed
@sr5434
sr5434 deleted the Function-prototype-bind-retain-proto branch October 1, 2026 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Function.prototype.bind does not preserve the target's prototype

2 participants